fix: use nc's binary finding logic for smb #48421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
Altahrim,
a team,
artonge and
sorbaugh
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
artonge
approved these changes
Sep 30, 2024
Altahrim
approved these changes
Sep 30, 2024
icewind1991
force-pushed
the
smb-systembridge
branch
3 times, most recently
from
ca2ae8e
to
119282a
Compare
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
smb-systembridge
branch
from
119282a
to
103b464
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bridge the nc and smb binary finding logic.
This should make the logic around finding the smb binaries less surprising.