fix(files): Move loading icon before grid toggle #47370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
design
susnux
requested review from
artonge and
Fenn-CS
and removed request for
a team
|
/backport to stable30 |
susnux
force-pushed
the
fix/loading-icon
branch
from
aa7e81d
to
9571ec1
Compare
|
/compile |
skjnldsv
approved these changes
Aug 21, 2024
artonge
approved these changes
Aug 21, 2024
This prevents jumping of that toggle button when the view is loading. Also adjust the design for Nextcloud 30 (prevent jumping of breadcrumbs when loading due to increased height). Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/loading-icon
branch
from
05e84a1
to
2d0f658
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This prevents jumping of that toggle button when the view is loading. Also adjust the design for Nextcloud 30 (prevent jumping of breadcrumbs when loading due to increased height).
Before
Bildschirmaufnahme_20240821_022625.webm
After
Bildschirmaufnahme_20240821_022550.webm
Checklist