fix(login): Also check legacy annotation for ephemeral sessions

Signed-off-by: Louis Chemineau <[email protected]>
nextcloud · Feb 27, 2025 · 47bd75a · 47bd75a
1 parent 7bab703
commit 47bd75a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/lib/private/AppFramework/DependencyInjection/DIContainer.php b/lib/private/AppFramework/DependencyInjection/DIContainer.php
@@ -217,12 +217,7 @@ public function __construct(string $appName, array $urlParams = [], ?ServerConta
 				)
 			);
 
-			$dispatcher->registerMiddleware(
-				new FlowV2EphemeralSessionsMiddleware(
-					$c->get(ISession::class),
-					$c->get(IUserSession::class),
-				)
-			);
+			$dispatcher->registerMiddleware($c->get(FlowV2EphemeralSessionsMiddleware::class));
 
 			$securityMiddleware = new SecurityMiddleware(
 				$c->get(IRequest::class),

diff --git a/lib/private/AppFramework/Middleware/FlowV2EphemeralSessionsMiddleware.php b/lib/private/AppFramework/Middleware/FlowV2EphemeralSessionsMiddleware.php
@@ -7,6 +7,7 @@
  */
 namespace OC\AppFramework\Middleware;
 
+use OC\AppFramework\Utility\ControllerMethodReflector;
 use OC\Core\Controller\ClientFlowLoginV2Controller;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Middleware;
@@ -20,6 +21,7 @@ class FlowV2EphemeralSessionsMiddleware extends Middleware {
 	public function __construct(
 		private ISession $session,
 		private IUserSession $userSession,
+		private ControllerMethodReflector $reflector,
 	) {
 	}
 
@@ -40,6 +42,10 @@ public function beforeController(Controller $controller, string $methodName) {
 			return;
 		}
 
+		if ($this->reflector->hasAnnotation('PublicPage')) {
+			return;
+		}
+
 		$this->userSession->logout();
 		$this->session->close();
 	}