Skip to content

feat(config): implement config lexicon #49577

feat(config): implement config lexicon

feat(config): implement config lexicon #49577

Triggered via pull request October 1, 2024 15:50
Status Failure
Total duration 28m 23s
Artifacts

static-code-analysis.yml

on: pull_request
static-code-analysis
4m 9s
static-code-analysis
static-code-analysis-security
13m 59s
static-code-analysis-security
static-code-analysis-ocp
2m 47s
static-code-analysis-ocp
Fit to window
Zoom out
Zoom in

Annotations

11 errors
static-code-analysis
Process completed with exit code 1.
InvalidArrayOffset: lib/private/AppConfig.php#L1579
lib/private/AppConfig.php:1579:53: InvalidArrayOffset: Cannot access value on variable $configDetails using offset value of 'strictness', expecting 'entries' or 'strict' (see https://psalm.dev/115)
InvalidReturnType: lib/private/AppConfig.php#L1641
lib/private/AppConfig.php:1641:13: InvalidReturnType: The declared return type 'array{entries: array<array-key, OCP\ConfigLexicon\IConfigLexiconEntry>, strict: bool}' for OC\AppConfig::getConfigDetailsFromLexicon is incorrect, got 'array{entries: array<array-key, OCP\ConfigLexicon\IConfigLexiconEntry>, strict?: bool, strictness?: OCP\ConfigLexicon\ConfigLexiconStrictness}' which is different due to additional array shape fields (strict, strictness) (see https://psalm.dev/011)
InvalidPropertyAssignmentValue: lib/private/AppConfig.php#L1652
lib/private/AppConfig.php:1652:4: InvalidPropertyAssignmentValue: $this->configLexiconDetails with declared type 'array<array-key, array{entries: array<array-key, OCP\ConfigLexicon\IConfigLexiconEntry>, strict: bool}>' cannot be assigned type 'non-empty-array<array-key, array{entries: array<array-key, OCP\ConfigLexicon\IConfigLexiconEntry>, strict?: bool, strictness?: OCP\ConfigLexicon\ConfigLexiconStrictness|enum(OCP\ConfigLexicon\ConfigLexiconStrictness::IGNORE)}>' (see https://psalm.dev/145)
InvalidReturnStatement: lib/private/AppConfig.php#L1658
lib/private/AppConfig.php:1658:10: InvalidReturnStatement: The inferred type 'array{entries: array<array-key, OCP\ConfigLexicon\IConfigLexiconEntry>, strict?: bool, strictness?: OCP\ConfigLexicon\ConfigLexiconStrictness}' does not match the declared return type 'array{entries: array<array-key, OCP\ConfigLexicon\IConfigLexiconEntry>, strict: bool}' for OC\AppConfig::getConfigDetailsFromLexicon due to additional array shape fields (strict, strictness) (see https://psalm.dev/128)
RedundantCast: lib/private/UserPreferences.php#L288
lib/private/UserPreferences.php:288:89: RedundantCast: Redundant cast to string (see https://psalm.dev/262)
MoreSpecificReturnType: lib/private/UserPreferences.php#L366
lib/private/UserPreferences.php:366:13: MoreSpecificReturnType: The declared return type 'list<string>' for OC\UserPreferences::searchUsersByValueString is more specific than the inferred return type 'array<array-key, mixed>' (see https://psalm.dev/070)
LessSpecificReturnStatement: lib/private/UserPreferences.php#L370
lib/private/UserPreferences.php:370:10: LessSpecificReturnStatement: The type 'array<array-key, mixed>' is more general than the declared return type 'list<string>' for OC\UserPreferences::searchUsersByValueString (see https://psalm.dev/129)
MoreSpecificReturnType: lib/private/UserPreferences.php#L394
lib/private/UserPreferences.php:394:13: MoreSpecificReturnType: The declared return type 'list<string>' for OC\UserPreferences::searchUsersByValues is more specific than the inferred return type 'array<array-key, mixed>' (see https://psalm.dev/070)
LessSpecificReturnStatement: lib/private/UserPreferences.php#L398
lib/private/UserPreferences.php:398:10: LessSpecificReturnStatement: The type 'array<array-key, mixed>' is more general than the declared return type 'list<string>' for OC\UserPreferences::searchUsersByValues (see https://psalm.dev/129)
static-code-analysis
Process completed with exit code 2.