Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the outdated tabbar with the sidebar which is unused #601

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update the outdated tabbar with the sidebar which is unused #601

wants to merge 3 commits into from

Conversation

newhinton
Copy link
Collaborator

@newhinton newhinton commented Jun 14, 2019 •
edited
Loading

This updates the sidebars, some css, and refactored services

@newhinton newhinton added this to the 2.3.2 milestone Jun 14, 2019
@newhinton newhinton self-assigned this Jun 14, 2019
@animalillo animalillo modified the milestones: 2.3.2, 2.3.3 Jul 8, 2019
@animalillo animalillo removed this from the 2.3.3 milestone Oct 20, 2019
animalillo
animalillo reviewed Oct 20, 2019
View reviewed changes
Copy link
Collaborator

@animalillo animalillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should check for a way to avoid using the RootScope and having some cleaner code

@binsky08
Copy link
Collaborator

i would really appreciate this feature, makes the ui cleaner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@animalillo animalillo animalillo left review comments

@brantje brantje Awaiting requested review from brantje

@Oliv4945 Oliv4945 Awaiting requested review from Oliv4945

Assignees

@newhinton newhinton

Labels
enhancement Needs Review needs testing review visual
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newhinton @binsky08 @animalillo