-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move messages to junk folder #8581
Conversation
$mailbox->getName(), | ||
$event->getUid(), | ||
$account, | ||
'INBOX', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we assume the name to be always exactly like that? what about capitalization? personal namspace?
0760af0
to
45d1f06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decide: Rename "Mark as Spam" to "Move to Spam" with checkbox "Move message to Junk" enabled
It should stay a simple "Mark as spam" action. It is expected from (the majority of) other clients that "Mark as spam" will also move it to spam/junk.
45d1f06
to
53bb020
Compare
53bb020
to
e28a726
Compare
1438330
to
cc52e74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works
|
Signed-off-by: Daniel Kesselberg <[email protected]>
d8fb535
to
45c5ab9
Compare
Follow-up as talked with @ChristophWurst and mentioned above:
Meaning the toggle to need to enable this functionality can be removed as it should be enabled by default. |
→ #8738 |
For #4101
To Do
Decide: Rename "Mark as Spam" to "Move to Spam" with checkbox "Move message to Junk" enabledTest cases