Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rework draft handling front-end #8469

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented May 11, 2023

Fixes #7077
Closes #4768

  • UC1
  • UC2
  • UC3 => will be solved in a separate PR
  • UC4
  • UC5
  • UC6

@ChristophWurst
Copy link
Member

quick check of the code looks clean

@JohannesGGE
Copy link
Contributor

There is something wrong with the background job.

UC1

  • local_messages still contains entry

UC2

  • works fine

UC3

  • local_messages entry is not converted and remains in db

UC4

  • works fine

UC5

  • works fine

UC6

  • UC1 -> works fine. local_messages entry seems to be deleted this time ('send_at' value is set)
  • UC2 -> works fine
  • UC3 -> local_messages up to date but not deleted. Draft in messages disappeared and no new updated version appears

@hamza221
Copy link
Contributor Author

UC3 still missing

@ChristophWurst ChristophWurst changed the title (WIP) Rework draft FE Rework draft handling front-end Jun 1, 2023
@hamza221 hamza221 marked this pull request as ready for review June 7, 2023 12:12
@ChristophWurst
Copy link
Member

UC1: the drafts are stored locally. adding more text updates that draft. sending puts the message into the outbox. but the message is not sent.

@ChristophWurst
Copy link
Member

ChristophWurst commented Jun 14, 2023

UC2 ✔️
UC4 ✔️
UC5 ✔️
UC6 ✔️

@ChristophWurst
Copy link
Member

UC1: the drafts are stored locally. adding more text updates that draft. sending puts the message into the outbox. but the message is not sent.

I think the only thing missing is starting a timer with the undo timeout and triggering a send of the new outbox message.

On systems with reliably cron the message will be sent after ~5mins. but I think the frontend should trigger sending right after the undo timeout.

@hamza221
Copy link
Contributor Author

hamza221 commented Jun 14, 2023

@ChristophWurst what do you think should be done for UC3? should we handle it in a separate issue ?

@ChristophWurst
Copy link
Member

Yes we can tackle UC3 separately

@hamza221
Copy link
Contributor Author

hamza221 commented Jun 14, 2023

The timer is already there but the message's sendAt was not updated correctly, Also I noticed that messages get enqueued when the draft is saved, I changed that too

Copy link
Contributor

@JohannesGGE JohannesGGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #8576 U3 works now.

I only noticed one small thing:
In UC5: When there is no change the composer doesn't close completly. The minimized composer stays. You have to click on close again on the minimized composer.

@hamza221
Copy link
Contributor Author

Can you please give it another check. should be working properly now

@ChristophWurst ChristophWurst changed the title Rework draft handling front-end feat: Rework draft handling front-end Jun 29, 2023
@ChristophWurst
Copy link
Member

Green CI. Time for a squash.

@ChristophWurst ChristophWurst added this to the v3.3.0 milestone Jun 29, 2023
@ChristophWurst ChristophWurst merged commit f7d0678 into main Jun 29, 2023
28 of 29 checks passed
@ChristophWurst ChristophWurst deleted the enh/rework-draft branch June 29, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework Draft Handling - Frontend Part Rework draft handling (on IMAP)
3 participants