-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rework draft handling front-end #8469
Conversation
quick check of the code looks clean |
There is something wrong with the background job. UC1
UC2
UC3
UC4
UC5
UC6
|
UC3 still missing |
UC1: the drafts are stored locally. adding more text updates that draft. sending puts the message into the outbox. but the message is not sent. |
UC2 ✔️ |
I think the only thing missing is starting a timer with the undo timeout and triggering a send of the new outbox message. On systems with reliably cron the message will be sent after ~5mins. but I think the frontend should trigger sending right after the undo timeout. |
@ChristophWurst what do you think should be done for UC3? should we handle it in a separate issue ? |
Yes we can tackle UC3 separately |
The timer is already there but the message's sendAt was not updated correctly, Also I noticed that messages get enqueued when the draft is saved, I changed that too |
6af1d60
to
811c1d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With #8576 U3 works now.
I only noticed one small thing:
In UC5: When there is no change the composer doesn't close completly. The minimized composer stays. You have to click on close again on the minimized composer.
Can you please give it another check. should be working properly now |
Green CI. Time for a squash. |
Signed-off-by: hamza221 <[email protected]>
b994b55
to
f1f757e
Compare
Fixes #7077
Closes #4768