Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check strict cookies for image proxy #8459

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

ChristophWurst
Copy link
Member

#2153 little sibling. It makes sense to check for the cookie existence here too.

How to test

  1. Set up an account
  2. Open a HTML message with external images
  3. Click Show images and Show images temporarily

main: images show
here: images show

@ChristophWurst
Copy link
Member Author

/backport to stable2.2

@ChristophWurst
Copy link
Member Author

/backport to 1.15

Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt test

Copy link
Contributor

@hamza221 hamza221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@ChristophWurst
Copy link
Member Author

/backport to stable3.2

@ChristophWurst ChristophWurst merged commit df22103 into main Jun 27, 2023
14 checks passed
@ChristophWurst ChristophWurst deleted the fix/image-proxy-strict-cookie-check branch June 27, 2023 10:15
@backportbot-nextcloud
Copy link

The backport to 1.15 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout 1.15
git pull origin 1.15

# Create the new backport branch
git checkout -b fix/foo-1.15

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-1.15

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants