Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mail translation #10453

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Add mail translation #10453

merged 1 commit into from
Jan 9, 2025

Conversation

GVodyanov
Copy link
Contributor

Fix #10386

@GVodyanov GVodyanov self-assigned this Dec 8, 2024
@SebastianKrupinski
Copy link
Contributor

Tested Works.

image

There are a few improvements I would make.

  • The from selector, I would put in a Detect Automatically option, as a user might not know what the original language is.
  • The best option would be to get rid of the from text selector, and just make the AI determine what the original language is.
  • Since we are using AI for this, don't limit the translation languages, I only have to option to translate to 3 languages, German, French and English. Also German is missing in the from selector.
  • Lower the time interval that checks if the task processing job is completed. On my dev system the job is completed in 2s but the UI takes almost 30s to display the translation.
  • Hide the original source once the translation is completed. I need to scroll past the original text first before I can see the translation.

src/store/mutations.js Show resolved Hide resolved
src/service/translationService.js Outdated Show resolved Hide resolved
src/components/MenuEnvelope.vue Show resolved Hide resolved
src/service/translationService.js Outdated Show resolved Hide resolved
@hamza221
Copy link
Contributor

hamza221 commented Jan 8, 2025

I Like the UI ✅

@hamza221 hamza221 marked this pull request as ready for review January 9, 2025 10:21
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/service/translationService.js Outdated Show resolved Hide resolved
@hamza221 hamza221 force-pushed the feat/mailTranslation branch from a3e41a9 to 638ecc5 Compare January 9, 2025 13:11
@hamza221 hamza221 enabled auto-merge January 9, 2025 13:11
@hamza221 hamza221 merged commit 6711d8e into main Jan 9, 2025
34 of 35 checks passed
@hamza221 hamza221 deleted the feat/mailTranslation branch January 9, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate email
4 participants