fix: use single connection to sync all mailboxes #10117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianKrupinski
requested review from
ChristophWurst,
kesselb and
GretaD
as code owners
kesselb
previously requested changes
Sep 8, 2024
ChristophWurst
requested changes
Sep 9, 2024
| @@ -109,6 +109,10 @@ public function syncAccount(Account $account, | |||
| $snoozeMailboxId = $account->getMailAccount()->getSnoozeMailboxId(); | |||
| $sentMailboxId = $account->getMailAccount()->getSentMailboxId(); | |||
| $trashRetentionDays = $account->getMailAccount()->getTrashRetentionDays(); | |||
| // construct imap client and perform initial connection | |||
| $client = $this->clientFactory->getClient($account); | |||
| $client->login(); | |||
|
Address the reviewer comments, otherwise this is showing full affect for a CLI sync of an account with 16 mailboxes. Before: 16 logins https://blackfire.io/profiles/compare/3e0e51dc-6586-40a6-9106-6c3625f41b7b/graph
👍 |
ChristophWurst
approved these changes
Sep 13, 2024
st3iny
approved these changes
Sep 15, 2024
|
/backport to stable4.0 |
|
/backport to stable3.7 |
Signed-off-by: SebastianKrupinski <[email protected]>
SebastianKrupinski
force-pushed
the
fix/issue-10098-mailbox-sync
branch
from
beef438
to
57389ba
Compare
kesselb
dismissed
their stale review
the comments, duplicating the code, were removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #10098