-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: retrieve body structure and process parts on mailbox sync #10046
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's be careful with the performance impact of this change.
The last time I tried, pulling structure increased the data transferred significantly. Hence we offloaded the processing to \OCA\Mail\Service\PreprocessingService::process
outside of the initial/partial sync, to keep the sync as fast as possible.
We also don't need to fetch this info for very old messages, because the invites imip messages are probably not relevant anymore.
Do you have any numbers on how much the amount of transferred data increases? An idea for measuring is
- Delete data/horde_imap.log
- Enable debug mode
- Change the imap connection factory to debug_literal=true
- Add an account via occ. The account should have at least a few thousand email in the INBOX
- Run occ mail:account:sync with blackfire attached
Then inspect the size of horde_imap.log
Do it twice with and without the changes.
Well you are correct... sort of... but the data transfer increase has nothing to do with adding BODYSTRUCTURE to the command... sort of... Let me explain.... I tested this with my main account that has about 12K of messages, the difference was about 200MB. Currently, With BODYSTRUCTURE, So the issue is the followup fetch and no the BODYSTRUCTURE. I will look in to fixing this. |
Signed-off-by: SebastianKrupinski <[email protected]>
Signed-off-by: SebastianKrupinski <[email protected]>
701de26
to
a44e4e5
Compare
Please update the pull request description what problem it does fix and how to reproduce the problem. |
Adjusted mail retrieval logic to pull body structure without contents on partial sync so that attachments (like iMip Messages) can be found.
Part 1 of iMip Messaging Refactoring