feat: mail provider backend

Signed-off-by: SebastianKrupinski <[email protected]>

lib/AppInfo/Application.php

@@ -158,7 +158,6 @@ public function register(IRegistrationContext $context): void {
 		}
 
 		// Added in version 4.0.0
-		// register mail provider
 		$context->registerMailProvider(MailProvider::class);
 
 		$context->registerNotifierService(Notifier::class);

lib/Db/MailAccountMapper.php

@@ -92,8 +92,6 @@ public function findByUserId(string $userId): array {
 	 * @param string $address mail address (e.g. [email protected])
 	 *
 	 * @return MailAccount[]
-	 *
-	 * @throws DoesNotExistException
 	 */
 	public function findByUserIdAndAddress(string $userId, string $address): array {
 		$qb = $this->db->getQueryBuilder();

lib/Provider/Command/MessageSend.php

@@ -40,9 +40,9 @@ public function __construct(
 	 * @param array $options array of options reserved for future use
 	 *
 	 * @return LocalMessage
-	 * 
+	 *
 	 * @throws SendException on failure, check message for reason
-	 * 
+	 *
 	 */
 	public function perform(string $userId, string $serviceId, IMessage $message, array $options = []): LocalMessage {
 		// find user mail account details

lib/Provider/MailProvider.php

@@ -83,7 +83,6 @@ public function listServices(string $userId): array {
 		$services = [];
 		// add services to collection
 		foreach ($accounts as $entry) {
-			// add service to collection
 			$services[(string)$entry->getId()] = $this->serviceFromAccount($userId, $entry);
 		}
 		// return list of services for user

tests/Unit/Provider/Command/MessageSendTest.php

@@ -23,20 +23,15 @@
 use OCP\Mail\Provider\Attachment;
 use OCP\Mail\Provider\Exception\SendException;
 use OCP\Mail\Provider\Message;
+use PHPUnit\Framework\MockObject\MockObject;
 
 class MessageSendTest extends TestCase {
-
-	/** @var IConfig&MockObject */
-	private $config;
-	/** @var ITimeFactory&MockObject */
-	private $time;
-	/** @var AccountService&MockObject */
-	private $accountService;
-	/** @var OutboxService&MockObject */
-	private $outboxService;
-	/** @var AttachmentService&MockObject */
-	private $attachmentService;
-	/** @var MessageSend */
+
+	private IConfig&MockObject $config;
+	private ITimeFactory&MockObject $time;
+	private AccountService&MockObject $accountService;
+	private OutboxService&MockObject $outboxService;
+	private AttachmentService&MockObject $attachmentService;
 	private $commandSend;
 
 	protected function setUp(): void {

tests/Unit/Provider/MailProviderTest.php

@@ -17,20 +17,17 @@
 use OCA\Mail\Service\AccountService;
 use OCP\IL10N;
 use OCP\Mail\Provider\Address as MailAddress;
+use PHPUnit\Framework\MockObject\MockObject;
 use Psr\Container\ContainerInterface;
 use Psr\Log\LoggerInterface;
 use Psr\Log\NullLogger;
 
 class MailProviderTest extends TestCase {
 
-	/** @var ContainerInterface&MockObject */
-	private $containerInterface;
-	/** @var AccountService&MockObject */
-	private $accountService;
-	/** @var LoggerInterface */
-	private $logger;
-	/** @var IL10N&MockObject */
-	private $l10n;
+	private ContainerInterface&MockObject $containerInterface;
+	private AccountService&MockObject $accountService;
+	private LoggerInterface $logger;
+	private IL10N&MockObject $l10n;
 
 	protected function setUp(): void {
 		parent::setUp();

tests/Unit/Provider/MailServiceTest.php

@@ -14,10 +14,9 @@
 use Psr\Container\ContainerInterface;
 
 class MailServiceTest extends TestCase {
-	/** @var MailService */
-	private $mailService;
-	/** @var Address */
-	private $primaryAddress;
+
+	private MailService $mailService;
+	private Address $primaryAddress;
 
 	protected function setUp(): void {
 		parent::setUp();