Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing div id (fixes CSS lack) #1227

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Add missing div id (fixes CSS lack) #1227

merged 1 commit into from
Aug 20, 2024

Conversation

Jerome-Herbinet
Copy link
Member

Tests from reviewers are welcome.

Before (without id)

2024-08-19_13-34

After (with id = CSS applies correctly)

2024-08-19_13-34_1

@Jerome-Herbinet Jerome-Herbinet added bug Something isn't working design Related to the design 3. to review Waiting for reviews papercut Small issues that doesn't break the ux/ui labels Aug 19, 2024
@Jerome-Herbinet Jerome-Herbinet changed the title Add missing div id Add missing div id (fixes CSS lack) Aug 19, 2024
jancborchardt
jancborchardt approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Pytal
Pytal reviewed Aug 19, 2024
View reviewed changes
src/components/GuestList.vue Outdated Show resolved Hide resolved
@Jerome-Herbinet @Pytal
Add missing css class (former id)
f34206a 
Signed-off-by: Jérôme Herbinet <[email protected]>

Add missing div id

Signed-off-by: Jérôme Herbinet <[email protected]>

Replace "guests-list" id with class

Signed-off-by: Jérôme Herbinet <[email protected]>
Co-Authored-By: Pytal <[email protected]>
@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-add-missing-div-id branch from 6664ce1 to f34206a Compare August 20, 2024 06:52
@Pytal Pytal merged commit 47e4b79 into master Aug 20, 2024
36 checks passed
@Pytal Pytal deleted the Jerome-Herbinet-add-missing-div-id branch August 20, 2024 18:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@Pytal Pytal Pytal approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working design Related to the design feedback-requested papercut Small issues that doesn't break the ux/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jerome-Herbinet @jancborchardt @Pytal