Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url decode 2.4 #1086

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Url decode 2.4 #1086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
587b409
use decoded path to check app whitelist
icewind1991 Dec 7, 2023
619f285
fix permissions for whitelist reset
icewind1991 Dec 7, 2023
76bf8c0
2.4.1
icewind1991 Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appinfo/info.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
Guests accounts can be created from the share menu by entering either the recipients email or name and choosing "create guest account", once the share is created the guest user will receive an email notification about the mail with a link to set their password.

Guests users can only access files shared to them and cannot create any files outside of shares, additionally, the apps accessible to guest accounts are whitelisted.]]></description>
<version>2.4.0</version>
<version>2.4.1</version>
<licence>agpl</licence>
<author>Nextcloud</author>
<types>
Expand Down
2 changes: 1 addition & 1 deletion lib/AppWhitelist.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public function isUrlAllowed(IUser $user, $url): bool {
}

public function verifyAccess(IUser $user, IRequest $request): void {
if (!$this->isUrlAllowed($user, $request->getRawPathInfo())) {
if (!$this->isUrlAllowed($user, $request->getPathInfo())) {
header('HTTP/1.0 403 Forbidden');
Template::printErrorPage($this->l10n->t(
'Access to this resource is forbidden for guests.'
Expand Down
2 changes: 0 additions & 2 deletions lib/Controller/SettingsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ public function setConfig(bool $useWhitelist, array $whitelist, bool $allowExter
* We do not set the whitelist to null when it is unused. This is by design.
* It allows remembering the whitelist throughout changes.
*
* @NoAdminRequired
* @return DataResponse with the current whitelist config
*/
public function getWhitelist(): DataResponse {
Expand All @@ -111,7 +110,6 @@ public function getWhitelist(): DataResponse {
/**
* AJAX handler for resetting the whitelisted apps
*
* @NoAdminRequired
* @return DataResponse with the reset whitelist
*/
public function resetWhitelist(): DataResponse {
Expand Down
Loading