Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include shareType in share select option data #1058

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

Fenn-CS
Copy link
Contributor

@Fenn-CS Fenn-CS commented Sep 6, 2023

The object that is built in src/main.js which is added to the user search bar is used to build a share object and for this app the shareType is guest, hence it should be included from the source.

Related to : nextcloud/server#40299

The object that is built in src/main.js which is added to the user
search bar is used to build a share object and for this app the
shareType is guest, hence it should be included from the source.

Related to : nextcloud/server#40299

Signed-off-by: fenn-cs <[email protected]>
@skjnldsv skjnldsv merged commit 0246ab8 into master Sep 6, 2023
18 checks passed
@skjnldsv skjnldsv deleted the add-sharetype-guest-invite-selectoption-data branch September 6, 2023 15:25
@AndyScherzinger
Copy link
Member

/backport to stable27

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Sep 6, 2023
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Sep 6, 2023

/backport to stable-2.5

@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants