Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix event dispatcher usage #1045

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Fix event dispatcher usage #1045

merged 6 commits into from
Aug 28, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 4, 2023 •
edited
Loading

The app breaks on master due to the unavoidable changes in the event dispatcher handling with the upcoming symfony update.

  • I recommend to create a new stable branch before this and then also to bump the major version of the app
  • I fixed CI to my best knowledge, but there are some more things that need adjusting it seems.

@nickvergessen nickvergessen added the 2. developing Work in progress label Aug 4, 2023
@nickvergessen nickvergessen mentioned this pull request Aug 4, 2023
Merged
4 tasks
@nickvergessen
Copy link
Member Author

Branched off stable-2.5 after talking to icewind

@nickvergessen nickvergessen force-pushed the bugfix/noid/fix-event-dispatcher-usage branch from c837262 to de60c65 Compare August 28, 2023 12:54
@nickvergessen nickvergessen force-pushed the bugfix/noid/fix-event-dispatcher-usage branch from de60c65 to bc723b1 Compare August 28, 2023 12:55
@nickvergessen nickvergessen mentioned this pull request Aug 28, 2023
Closed
icewind1991
icewind1991 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@icewind1991 icewind1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic functionality still seems to work

@icewind1991 icewind1991 merged commit 447e70c into master Aug 28, 2023
29 checks passed
@icewind1991 icewind1991 deleted the bugfix/noid/fix-event-dispatcher-usage branch August 28, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees
No one assigned
Labels
2. developing Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @icewind1991