fix: reuse share object instead of getting it again when sending invi…

…te mail Signed-off-by: Robin Appelman <[email protected]>
nextcloud · Mar 5, 2024 · d25ef91 · d25ef91
1 parent 75a31a1
commit d25ef91
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 17 deletions.
diff --git a/lib/Hooks.php b/lib/Hooks.php
@@ -162,8 +162,7 @@ public function handlePostShare(ShareCreatedEvent $event): void {
 				$this->mail->sendGuestInviteMail(
 					$uid,
 					$shareWith,
-					$share->getNodeType(),
-					$share->getNodeId(),
+					$share,
 					$token,
 					$lang
 				);

diff --git a/lib/Mail.php b/lib/Mail.php
@@ -84,7 +84,7 @@ public function __construct(
 	 * @param $uid
 	 * @throws \Exception
 	 */
-	public function sendGuestInviteMail(string $uid, string $shareWith, string $itemType, string $itemSource, string $token, string $language = ''): void {
+	public function sendGuestInviteMail(string $uid, string $shareWith, Share\IShare $share, string $token, string $language = ''): void {
 		if ($language === '') {
 			$language = null;
 		}
@@ -102,22 +102,12 @@ public function sendGuestInviteMail(string $uid, string $shareWith, string $item
 		$replyTo = $this->userManager->get($uid)->getEMailAddress();
 		$senderDisplayName = $this->userSession->getUser()->getDisplayName();
 
-		$items = Share::getItemSharedWithUser($itemType, $itemSource, $shareWith);
-		$filename = trim($items[0]['file_target'], '/');
-		$subject = (string)$l10n->t('%s shared »%s« with you', [$senderDisplayName, $filename]);
-		$expiration = null;
-		if (isset($items[0]['expiration'])) {
-			try {
-				$date = new \DateTime($items[0]['expiration']);
-				$expiration = $date->getTimestamp();
-			} catch (\Exception $e) {
-				$this->logger->error("Couldn't read date: " . $e->getMessage(), ['app' => 'sharing']);
-			}
-		}
-
+		$filename = trim($share->getTarget(), '/');
+		$subject = $l10n->t('%s shared »%s« with you', [$senderDisplayName, $filename]);
+		$expiration = $share->getExpirationDate();
 
 		$link = $this->urlGenerator->linkToRouteAbsolute(
-			'files.viewcontroller.showFile', ['fileid' => $itemSource]
+			'files.viewcontroller.showFile', ['fileid' => $share->getNodeId()]
 		);
 
 		$emailTemplate = $this->mailer->createEMailTemplate('guest.invite');