fix(psalm): Fix all @throws annotations and add missing ones

lib/ACL/ACLManager.php

@@ -11,6 +11,7 @@
 use OCA\GroupFolders\Trash\TrashManager;
 use OCP\Cache\CappedMemoryCache;
 use OCP\Constants;
+use OCP\DB\Exception;
 use OCP\Files\IRootFolder;
 use OCP\IUser;
 use Psr\Log\LoggerInterface;
@@ -206,6 +207,7 @@ private function calculatePermissionsForPath(array $rules): int {
 
 	/**
 	 * Get the combined "lowest" permissions for an entire directory tree
+	 * @throws Exception
 	 */
 	public function getPermissionsForTree(string $path): int {
 		$path = ltrim($path, '/');
@@ -223,6 +225,9 @@ public function getPermissionsForTree(string $path): int {
 		}, Constants::PERMISSION_ALL);
 	}
 
+	/**
+	 * @throws Exception
+	 */
 	public function preloadRulesForFolder(string $path): void {
 		$this->ruleManager->getRulesForFilesByParent($this->user, $this->getRootStorageId(), $path);
 	}

lib/ACL/ACLStorageWrapper.php

@@ -12,6 +12,7 @@
 use OC\Files\Cache\Scanner;
 use OC\Files\Storage\Wrapper\Wrapper;
 use OCP\Constants;
+use OCP\DB\Exception;
 use OCP\Files\Cache\ICache;
 use OCP\Files\Storage\IStorage;
 
@@ -148,6 +149,7 @@ public function unlink($path): bool {
 	/**
 	 * When deleting we need to ensure that there is no file inside the folder being deleted that misses delete permissions
 	 * This check is fairly expensive so we only do it for the actual delete and not metadata operations
+	 * @throws Exception
 	 */
 	private function canDeleteTree(string $path): int {
 		return $this->aclManager->getPermissionsForTree($path) & Constants::PERMISSION_DELETE;

lib/ACL/RuleManager.php

@@ -10,6 +10,7 @@
 
 use OCA\GroupFolders\ACL\UserMapping\IUserMapping;
 use OCA\GroupFolders\ACL\UserMapping\IUserMappingManager;
+use OCP\DB\Exception;
 use OCP\DB\QueryBuilder\ICompositeExpression;
 use OCP\DB\QueryBuilder\IQueryBuilder;
 use OCP\EventDispatcher\IEventDispatcher;
@@ -42,6 +43,7 @@ private function createRule(array $data): ?Rule {
 	/**
 	 * @param int[] $fileIds
 	 * @return array<int, Rule[]>
+	 * @throws Exception
 	 */
 	public function getRulesForFilesById(IUser $user, array $fileIds): array {
 		$userMappings = $this->userMappingManager->getMappingsForUser($user);
@@ -107,6 +109,7 @@ public function getRulesForFilesByPath(IUser $user, int $storageId, array $fileP
 
 	/**
 	 * @return array<string, Rule[]>
+	 * @throws Exception
 	 */
 	public function getRulesForFilesByParent(IUser $user, int $storageId, string $parent): array {
 		$userMappings = $this->userMappingManager->getMappingsForUser($user);
@@ -153,6 +156,9 @@ public function getRulesForFilesByParent(IUser $user, int $storageId, string $pa
 		return $result;
 	}
 
+	/**
+	 * @throws Exception
+	 */
 	private function getId(int $storageId, string $path): int {
 		$query = $this->connection->getQueryBuilder();
 		$query->select(['fileid'])
@@ -166,6 +172,7 @@ private function getId(int $storageId, string $path): int {
 	/**
 	 * @param string[] $filePaths
 	 * @return array<string, Rule[]>
+	 * @throws Exception
 	 */
 	public function getAllRulesForPaths(int $storageId, array $filePaths): array {
 		$hashes = array_map(fn (string $path): string => md5(trim($path, '/')), $filePaths);
@@ -198,6 +205,7 @@ private function rulesByPath(array $rows, array $result = []): array {
 
 	/**
 	 * @return array<string, Rule[]>
+	 * @throws Exception
 	 */
 	public function getAllRulesForPrefix(int $storageId, string $prefix): array {
 		$query = $this->connection->getQueryBuilder();
@@ -217,6 +225,7 @@ public function getAllRulesForPrefix(int $storageId, string $prefix): array {
 
 	/**
 	 * @return array<string, Rule[]>
+	 * @throws Exception
 	 */
 	public function getRulesForPrefix(IUser $user, int $storageId, string $prefix): array {
 		$userMappings = $this->userMappingManager->getMappingsForUser($user);
@@ -240,6 +249,9 @@ public function getRulesForPrefix(IUser $user, int $storageId, string $prefix):
 		return $this->rulesByPath($rows);
 	}
 
+	/**
+	 * @throws Exception
+	 */
 	private function hasRule(IUserMapping $mapping, int $fileId): bool {
 		$query = $this->connection->getQueryBuilder();
 		$query->select('fileid')
@@ -251,6 +263,9 @@ private function hasRule(IUserMapping $mapping, int $fileId): bool {
 		return (bool)$query->executeQuery()->fetch();
 	}
 
+	/**
+	 * @throws Exception
+	 */
 	public function saveRule(Rule $rule): void {
 		if ($this->hasRule($rule->getUserMapping(), $rule->getFileId())) {
 			$query = $this->connection->getQueryBuilder();
@@ -315,6 +330,9 @@ public function saveRule(Rule $rule): void {
 		}
 	}
 
+	/**
+	 * @throws Exception
+	 */
 	public function deleteRule(Rule $rule): void {
 		$query = $this->connection->getQueryBuilder();
 		$query->delete('group_folders_acl')

lib/AppInfo/Application.php

@@ -56,8 +56,10 @@
 use OCP\IUserManager;
 use OCP\IUserSession;
 use OCP\Server;
+use Psr\Container\ContainerExceptionInterface;
 use Psr\Container\ContainerInterface;
 use Psr\Log\LoggerInterface;
+use Throwable;
 
 class Application extends App implements IBootstrap {
 	public const APP_ID = 'groupfolders';
@@ -227,6 +229,10 @@ public function register(IRegistrationContext $context): void {
 		$context->registerMiddleware(AuthorizedAdminSettingMiddleware::class);
 	}
 
+	/**
+	 * @throws ContainerExceptionInterface
+	 * @throws Throwable
+	 */
 	public function boot(IBootContext $context): void {
 		$context->injectFn(function (IMountProviderCollection $mountProviderCollection, CacheListener $cacheListener, IEventDispatcher $eventDispatcher): void {
 			$mountProviderCollection->registerProvider(Server::get(MountProvider::class));

lib/AppInfo/Capabilities.php

@@ -7,9 +7,11 @@
  */
 namespace OCA\GroupFolders\AppInfo;
 
+use OCA\Circles\Exceptions\RequestBuilderException;
 use OCA\GroupFolders\Folder\FolderManager;
 use OCP\App\IAppManager;
 use OCP\Capabilities\ICapability;
+use OCP\DB\Exception;
 use OCP\IUser;
 use OCP\IUserSession;
 
@@ -21,6 +23,10 @@ public function __construct(
 	) {
 	}
 
+	/**
+	 * @throws Exception
+	 * @throws RequestBuilderException
+	 */
 	public function getCapabilities(): array {
 		$user = $this->userSession->getUser();
 		if (!$user) {
@@ -35,6 +41,10 @@ public function getCapabilities(): array {
 		];
 	}
 
+	/**
+	 * @throws RequestBuilderException
+	 * @throws Exception
+	 */
 	private function hasFolders(IUser $user): bool {
 		$folders = $this->folderManager->getFoldersForUser($user);
 		return count($folders) > 0;

lib/AuthorizedAdminSettingMiddleware.php

@@ -27,6 +27,7 @@ public function __construct(
 
 	/**
 	 * Throws an error when the user is not allowed to use the app's APIs
+	 * @throws Exception
 	 */
 	public function beforeController(Controller $controller, string $methodName): void {
 		$method = new ReflectionMethod($controller, $methodName);

lib/BackgroundJob/ExpireGroupVersions.php

@@ -13,6 +13,7 @@
 use OCA\GroupFolders\Versions\GroupVersionsExpireManager;
 use OCP\AppFramework\Utility\ITimeFactory;
 use OCP\BackgroundJob\TimedJob;
+use OCP\DB\Exception;
 use OCP\IAppConfig;
 use Psr\Log\LoggerInterface;
 
@@ -36,6 +37,7 @@ public function __construct(
 	 * @inheritDoc
 	 * Expiring groupfolder versions can be quite expensive.
 	 * We need to limit the amount of folders we expire per run.
+	 * @throws Exception
 	 */
 	protected function run(mixed $argument): void {
 		$lastFolder = $this->appConfig->getValueInt(Application::APP_ID, 'cron_last_folder_index', 0);

lib/Command/Create.php

@@ -10,17 +10,26 @@
 
 use OC\Core\Command\Base;
 use OCA\GroupFolders\Folder\FolderManager;
+use OCP\DB\Exception;
+use Symfony\Component\Console\Exception\InvalidArgumentException;
+use Symfony\Component\Console\Exception\LogicException;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Create extends Base {
+	/**
+	 * @throws LogicException
+	 */
 	public function __construct(
 		private FolderManager $folderManager,
 	) {
 		parent::__construct();
 	}
 
+	/**
+	 * @throws InvalidArgumentException
+	 */
 	protected function configure(): void {
 		$this
 			->setName('groupfolders:create')
@@ -29,6 +38,10 @@ protected function configure(): void {
 		parent::configure();
 	}
 
+	/**
+	 * @throws Exception
+	 * @throws InvalidArgumentException
+	 */
 	protected function execute(InputInterface $input, OutputInterface $output): int {
 		$id = $this->folderManager->createFolder($input->getArgument('name'));
 		$output->writeln((string)$id);

lib/Command/ExpireGroup/ExpireGroupBase.php

@@ -9,17 +9,25 @@
 namespace OCA\GroupFolders\Command\ExpireGroup;
 
 use OC\Core\Command\Base;
+use Symfony\Component\Console\Exception\InvalidArgumentException;
+use Symfony\Component\Console\Exception\LogicException;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
 /**
  * Base class for the group folder expiration commands.
  */
 class ExpireGroupBase extends Base {
+	/**
+	 * @throws LogicException
+	 */
 	public function __construct() {
 		parent::__construct();
 	}
 
+	/**
+	 * @throws InvalidArgumentException
+	 */
 	protected function configure(): void {
 		$this
 			->setName('groupfolders:expire')

lib/Command/ExpireGroupVersionsPlaceholder.php

@@ -9,10 +9,14 @@
 namespace OCA\GroupFolders\Command;
 
 use OC\Core\Command\Base;
+use Symfony\Component\Console\Exception\InvalidArgumentException;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class ExpireGroupVersionsPlaceholder extends Base {
+	/**
+	 * @throws InvalidArgumentException
+	 */
 	protected function configure(): void {
 		$this
 			->setName('groupfolders:expire')

lib/Command/FolderCommand.php

@@ -11,15 +11,20 @@
 use OC\Core\Command\Base;
 use OCA\GroupFolders\Folder\FolderManager;
 use OCA\GroupFolders\Mount\MountProvider;
+use OCP\DB\Exception;
 use OCP\Files\IRootFolder;
+use Symfony\Component\Console\Exception\InvalidArgumentException;
+use Symfony\Component\Console\Exception\LogicException;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
 /**
  * Base command for commands asking the user for a folder id.
  */
 abstract class FolderCommand extends Base {
-
+	/**
+	 * @throws LogicException
+	 */
 	public function __construct(
 		protected FolderManager $folderManager,
 		protected IRootFolder $rootFolder,
@@ -30,6 +35,8 @@ public function __construct(
 
 	/**
 	 * @psalm-return ?array{id: mixed, mount_point: string, groups: array<empty, empty>|mixed, quota: int, size: int|mixed, acl: bool}
+	 * @throws Exception
+	 * @throws InvalidArgumentException
 	 */
 	protected function getFolder(InputInterface $input, OutputInterface $output): ?array {
 		$folderId = (int)$input->getArgument('folder_id');

lib/Command/ListCommand.php

@@ -11,9 +11,12 @@
 use OC\Core\Command\Base;
 use OCA\GroupFolders\Folder\FolderManager;
 use OCP\Constants;
+use OCP\DB\Exception;
 use OCP\Files\IRootFolder;
 use OCP\IGroupManager;
 use OCP\IUserManager;
+use Symfony\Component\Console\Exception\InvalidArgumentException;
+use Symfony\Component\Console\Exception\LogicException;
 use Symfony\Component\Console\Helper\Table;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
@@ -28,7 +31,9 @@ class ListCommand extends Base {
 		Constants::PERMISSION_DELETE => 'delete'
 	];
 
-
+	/**
+	 * @throws LogicException
+	 */
 	public function __construct(
 		private FolderManager $folderManager,
 		private IRootFolder $rootFolder,
@@ -38,6 +43,9 @@ public function __construct(
 		parent::__construct();
 	}
 
+	/**
+	 * @throws InvalidArgumentException
+	 */
 	protected function configure(): void {
 		$this
 			->setName('groupfolders:list')
@@ -46,6 +54,10 @@ protected function configure(): void {
 		parent::configure();
 	}
 
+	/**
+	 * @throws Exception
+	 * @throws InvalidArgumentException
+	 */
 	protected function execute(InputInterface $input, OutputInterface $output): int {
 		$userId = $input->getOption('user');
 		$groups = $this->groupManager->search('');