Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor checking if user is allowed to edit the form #2335

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

Chartman123
Copy link
Collaborator

No description provided.

@Chartman123 Chartman123 added php PHP related ticket 3. to review Waiting for reviews technical debt Technical issue labels Sep 23, 2024
@Chartman123 Chartman123 added this to the 4.3 milestone Sep 23, 2024
@Chartman123 Chartman123 self-assigned this Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@13b1f00). Learn more about missing BASE report.
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2335   +/-   ##
=======================================
  Coverage        ?   36.26%           
  Complexity      ?     1011           
=======================================
  Files           ?       70           
  Lines           ?     3814           
  Branches        ?        0           
=======================================
  Hits            ?     1383           
  Misses          ?     2431           
  Partials        ?        0           

Copy link
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not test this in depth but code looks fine to me!

@Chartman123
Copy link
Collaborator Author

Yes, I just searched where the two checks from getFormIfAllowed occured and replaced them with it :)

@Chartman123 Chartman123 merged commit b40ef76 into main Sep 24, 2024
50 checks passed
@Chartman123 Chartman123 deleted the chore/refactor-formAccessChecking branch September 24, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews php PHP related ticket technical debt Technical issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants