chore: Refactor lastUpdated

[Chartman123]

This commit refactors the form creation and update logic in the ApiController class. It removes the unnecessary setting of the created and lastUpdated timestamps in the Form entity, as these values are now automatically set in the FormMapper class. This improves code readability and reduces redundancy.

The changes also include updates to the FormMapper class, where the insert and update methods now automatically set the created and lastUpdated timestamps respectively.

[codecov]

Codecov Report

Attention: Patch coverage is 21.62162% with 29 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@b40ef76). Learn more about missing BASE report.
Report is 177 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2314   +/-   ##
=======================================
  Coverage        ?   36.25%           
  Complexity      ?     1011           
=======================================
  Files           ?       70           
  Lines           ?     3801           
  Branches        ?        0           
=======================================
  Hits            ?     1378           
  Misses          ?     2423           
  Partials        ?        0           

[Chartman123]

@susnux do you have any idea why I get an Error 500 as soon as I open the Forms app?

Type: Error
Code: 0
Message: Xdebug has detected a possible infinite loop, and aborted your script with a stack depth of '512' frames
File: /srv/www/htdocs/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php
Line: 104

[Chartman123]

@susnux I was able to resolve my issue (thanks to @come-nc)

This can now be reviewed. I currently needed a little hack in the ApiControllerTest to make them pass. (state and lastUpdated don't have the expected values in line 499. null instead of 0 and 0 instead of 123456789).

[Chartman123]

@Koc thanks for the approval. Do you perhaps have an idea how to fix the test in a better way? I'm no expert in tests 🙈😂

[Koc]

Usually it is recommended to rely on Psr\Clock\ClockInterface instead of plain time() and use MockClock implementation in tests.

Another variant - you can mock native time() by defining mocked function inside same namespace.

But I think we can live with current approach.

[Chartman123]

Yes we can leave it for now and add a to-do comment. What bothers me the most is that the time() mocking worked before but doesn't anymore. Probably because the timestamp generation is now moved from the ApiController to the FormMapper

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)