-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not submit fields that not exists anymore #2312
Do not submit fields that not exists anymore #2312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch :)
However, with your changes the values for Dropdown, Date and Time questions aren't loaded anymore. Other than that some small comments/improvements to the code.
Instead of doing it when loading from LocalStorage we could also check it on submission and remove answers for invalid questions there. What do you think?
Maybe rather show a warning like: "Warning the form has changed since you last visit, do you want to restart?" |
541a39d
to
0478938
Compare
Signed-off-by: Kostiantyn Miakshyn <[email protected]>
0478938
to
e4779f7
Compare
@Chartman123 thanx for suggestion, I've changed approach @susnux yeah, we can, but let's fix issue first. BTW what component can I use for raising this warning? |
@Koc I'll have a look at it and test it this evening :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, works much better now. Just one small question :)
You should use NcDialog like the two existing ones in Submit.vue :) |
This pr aims to fix next bug. Here a reproducer:
Expected result: form successfully submitted
Actual result: there is an error on BE side