fix: make FilePicker work with latest dialogs #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chartman123
added
3. to review
Chartman123
force-pushed
the
fix/filePicker
branch
from
7e422db
to
3a2cae5
Compare
|
Change in .prettierignore is unrelated but necessary after latest workflow update for not having to reformat it after every update. |
|
@susnux I could track it down that this error only happens when directories are allowed in the picker. When they are disallowed the error is gone, but of course you can't choose a directory for storage then... |
Chartman123
force-pushed
the
fix/filePicker
branch
from
6e31326
to
7d052d0
Compare
Signed-off-by: Christian Hartmann <[email protected]>
Chartman123
force-pushed
the
fix/filePicker
branch
from
7d052d0
to
738731e
Compare
susnux
reviewed
Aug 24, 2024
susnux
reviewed
Aug 24, 2024
Co-authored-by: Ferdinand Thiessen <[email protected]> Signed-off-by: Chartman123 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2298 by adjusting the conditionnal logic in the buttonFactory