-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: unify __construct functions #2270
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2270 +/- ##
=======================================
Coverage ? 45.05%
Complexity ? 813
=======================================
Files ? 68
Lines ? 3072
Branches ? 0
=======================================
Hits ? 1384
Misses ? 1688
Partials ? 0 |
d82b036
to
68efc7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice refactoring!
I also tried to do it for the DB classes but got lots of errors so I left them as they are for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the whitespace issue this looks good!
Signed-off-by: Christian Hartmann <[email protected]>
68efc7f
to
c22c515
Compare
@susnux I saw some errors like this one:
It's coming from this line: However I wasn't able to reliably reproduce it. Do you know how to fix it? I tried it with adding an |
No description provided.