Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring: move code to separate function storeAnswersForQuestion #1866

Conversation

tpokorra
Copy link
Contributor

@tpokorra tpokorra commented Jan 5, 2024

this helps in preparation for #1110

I am not ready to submit the pull request #1690 for issue #1110 yet, because I have not added new tests yet.
But rebasing is difficult with this refactoring.
Also it might make the review for the big pull request easier, if this small pull request is already done.

@tpokorra tpokorra force-pushed the TP-202401-refactoring_storeAnswersForQuestion branch 2 times, most recently from 81554b2 to 9698fb2 Compare January 5, 2024 07:08
this helps in preparation for nextcloud#1110

Signed-off-by: Timotheus Pokorra <[email protected]>
@tpokorra tpokorra force-pushed the TP-202401-refactoring_storeAnswersForQuestion branch from 9698fb2 to f24a595 Compare January 5, 2024 07:10
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (082e93b) 44.59% compared to head (f24a595) 44.62%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1866      +/-   ##
============================================
+ Coverage     44.59%   44.62%   +0.02%     
- Complexity      657      658       +1     
============================================
  Files            58       58              
  Lines          2592     2593       +1     
============================================
+ Hits           1156     1157       +1     
  Misses         1436     1436              

@Chartman123 Chartman123 added php PHP related ticket 3. to review Waiting for reviews technical debt Technical issue feature: 📝 submitting responses labels Jan 5, 2024
@Chartman123 Chartman123 added this to the 4.1 milestone Jan 5, 2024
@Chartman123
Copy link
Collaborator

/backport to stable3

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jan 5, 2024
@Chartman123 Chartman123 merged commit f08c222 into nextcloud:main Jan 5, 2024
47 checks passed
@tpokorra tpokorra deleted the TP-202401-refactoring_storeAnswersForQuestion branch January 5, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot feature: 📝 submitting responses php PHP related ticket technical debt Technical issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants