Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(dev): Migrate from webpack to vite for building the frontend #1827

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

susnux
Copy link
Collaborator

@susnux susnux commented Dec 9, 2023

Using vite over webpack has some benefits like better treeshaking and faster compile times (due to use of esbuild vs terser). So for forms this means:

build script size (du -bs js) without source maps
webpack 8939919 B
vite 2315149 B

This can not be backported because module JS is only supported since Nextcloud 27.

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Merging #1827 (f228767) into main (7a147d9) will increase coverage by 0.19%.
Report is 23 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1827      +/-   ##
============================================
+ Coverage     43.96%   44.15%   +0.19%     
  Complexity      646      646              
============================================
  Files            58       58              
  Lines          2550     2539      -11     
============================================
  Hits           1121     1121              
+ Misses         1429     1418      -11     

@Chartman123 Chartman123 merged commit efab02d into main Dec 11, 2023
43 of 44 checks passed
@Chartman123 Chartman123 deleted the feat/vite branch December 11, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants