enh: Allow to set results_delete permission on the frontend
#1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
susnux
force-pushed
the
enh/add-ui-for-delete-permission
branch
from
abe1cd1
to
d5dd10a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1805 +/- ##
============================================
+ Coverage 43.96% 44.73% +0.77%
- Complexity 646 649 +3
============================================
Files 58 58
Lines 2550 2555 +5
============================================
+ Hits 1121 1143 +22
+ Misses 1429 1412 -17 |
susnux
force-pushed
the
enh/add-ui-for-delete-permission
branch
from
d5dd10a
to
2b27242
Compare
Chartman123
reviewed
Nov 28, 2023
Chartman123
force-pushed
the
enh/add-ui-for-delete-permission
branch
from
2b27242
to
93ecf2c
Compare
susnux
force-pushed
the
enh/add-ui-for-delete-permission
branch
from
93ecf2c
to
e30651f
Compare
susnux
force-pushed
the
enh/add-ui-for-delete-permission
branch
2 times, most recently
from
31c8469
to
6d09699
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Chartman123
force-pushed
the
enh/add-ui-for-delete-permission
branch
from
6d09699
to
d23e0d7
Compare
Chartman123
approved these changes
Dec 10, 2023
|
/backport to stable3 |
backportbot-nextcloud
bot
added
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to set the permission for deleting submissions. Also fix the permission check when deleting submission to allow any user with permission to delete a submission instead of restricting to form owner.