Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: Show confirmation dialog before submitting an empty form #1803

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

susnux
Copy link
Collaborator

@susnux susnux commented Nov 28, 2023

When submitting and empty form a confirmation dialog is shown, to make sure users submitted willingly an empty form.
Also please note the missing padding of the text in the dialog will be fixed with the next nextcloud-vue update (is a component bug not related to this PR).

vokoscreenNG-2023-11-28_21-29-30.mp4

Note: This can not be backported due to missing NcDialog in nextcloud-vue 7.

@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews feature: 📝 submitting responses labels Nov 28, 2023
@susnux susnux added this to the 4.0 milestone Nov 28, 2023
@Chartman123 Chartman123 merged commit c0871fd into main Nov 28, 2023
34 checks passed
@Chartman123 Chartman123 deleted the feat/confirm-submit-empty branch November 28, 2023 23:24
@jancborchardt
Copy link
Member

Was on vacation last week so only saw this now, some late design feedback @susnux :)

  • There is very little outside padding, especially visible on the left of the content text and on the right and bottom of the buttons. Is this not handled by the component cc @marcoambrosini @szaimen ?
  • We generally don’t use the wording "Abort" but instead "Cancel"
  • The "Cancel" button does not need an icon as that calls for too much attention again despite being secondary :)

@szaimen
Copy link

szaimen commented Dec 4, 2023

  • There is very little outside padding, especially visible on the left of the content text and on the right and bottom of the buttons. Is this not handled by the component cc @marcoambrosini @szaimen ?

Indeed the confirm modal looks strange. @susnux any idea why?

@susnux
Copy link
Collaborator Author

susnux commented Dec 4, 2023

As written in the initial post the padding is caused by a component bug fixed in nextcloud vue 8.3

@szaimen
Copy link

szaimen commented Dec 4, 2023

As written in the initial post the padding is caused by a component bug fixed in nextcloud vue 8.3

all right, thanks! :)

@susnux
Copy link
Collaborator Author

susnux commented Dec 4, 2023

  • We generally don’t use the wording "Abort" but instead "Cancel"

  • The "Cancel" button does not need an icon as that calls for too much attention again despite being secondary :)

Ok will change this , thank you for the feedback :)

@jancborchardt
Copy link
Member

Awesome @susnux, and sorry for missing your remark in the original post! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to deal with empty responses
4 participants