Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(phpunit): Switch to phpunit workflow from organization #1795

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

susnux
Copy link
Collaborator

@susnux susnux commented Nov 27, 2023

No description provided.

@susnux susnux added the 3. to review Waiting for reviews label Nov 27, 2023
@susnux susnux force-pushed the fix/ci-phpunit branch 10 times, most recently from d439d94 to 685a62b Compare November 27, 2023 23:17
@susnux
Copy link
Collaborator Author

susnux commented Nov 27, 2023

Only integration is failing, but I do not understand:
The form that is exported is not anonymous, so all users should be returned by their ID / displayname.
Why did the test ever expect to return anonymous?

@Chartman123
Copy link
Collaborator

Chartman123 commented Nov 28, 2023

Why did the test ever expect to return anonymous?

In the current PHPUnit-WF we created one user user1, user2 and user3 did not exist in the test environment. Might this be the cause for this?

- name: Set up Nextcloud
env:
DB_PORT: 4444
OC_PASS: test
run: |
mkdir data
./occ maintenance:install --verbose --database=${{ matrix.databases }} --database-name=nextcloud --database-host=127.0.0.1 --database-port=$DB_PORT --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
./occ user:add --password-from-env --display-name="Test Displayname" test
./occ user:add --password-from-env --display-name="User No. 1" user1
./occ app:enable --force ${{ env.APP_NAME }}
php -S localhost:8080 &

@susnux
Copy link
Collaborator Author

susnux commented Nov 28, 2023

Ah yes I see so it tests for user2 and user3 are deleted users...

@susnux
Copy link
Collaborator Author

susnux commented Nov 28, 2023

Not related but maybe we then need to anonymize reponses on user-deleted events, because otherwise they would be connected to new users with the same ID

@susnux susnux force-pushed the fix/ci-phpunit branch 2 times, most recently from 058fc4d to 343f6eb Compare November 28, 2023 12:48
@Chartman123
Copy link
Collaborator

Ah yes I see so it tests for user2 and user3 are deleted users...

Yes, that's how I understand it

@Chartman123
Copy link
Collaborator

Not related but maybe we then need to anonymize reponses on user-deleted events, because otherwise they would be connected to new users with the same ID

Good idea :) could you please create a new issue for that?

@susnux
Copy link
Collaborator Author

susnux commented Nov 28, 2023

Nice ci is now happy :)

If you approve I can adjust the required workflows for the new workflow names of PHPUnit .

@Chartman123 Chartman123 merged commit 0471d64 into main Nov 28, 2023
44 checks passed
@Chartman123 Chartman123 deleted the fix/ci-phpunit branch November 28, 2023 13:47
@Chartman123 Chartman123 added this to the 4.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants