Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make components compatible to nextcloud-vue 8 #1696

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Make components compatible to nextcloud-vue 8 #1696

merged 3 commits into from
Nov 28, 2023

Conversation

Chartman123
Copy link
Collaborator

This adds compatibility to nextcloud-vue v8 following the pinned post there:

nextcloud-libraries/nextcloud-vue#4223

@Chartman123 Chartman123 added 2. developing Work in progress technical debt Technical issue Do not merge Don't merge, as it will break master (e.g. due to pending dependency) labels Aug 22, 2023
@Chartman123 Chartman123 self-assigned this Aug 22, 2023
@Chartman123
Copy link
Collaborator Author

grafik

@nextcloud/designers Do we need to invert the icon in the navigation for the selected form?

@susnux Could you please have a look at my changes regarding NcEmptyContent? I think that in some cases it's not properly centered.

@Chartman123 Chartman123 added javascript Javascript related ticket design Related to the design 3. to review Waiting for reviews and removed 2. developing Work in progress Do not merge Don't merge, as it will break master (e.g. due to pending dependency) labels Nov 27, 2023
@Chartman123 Chartman123 added this to the 4.0 milestone Nov 27, 2023
@susnux
Copy link
Collaborator

susnux commented Nov 27, 2023

@nextcloud/designers Do we need to invert the icon in the navigation for the selected form?

No this is a bug with @nextcloud/vue for active state it should set the text color correctly...

@susnux
Copy link
Collaborator

susnux commented Nov 28, 2023

@susnux Could you please have a look at my changes regarding NcEmptyContent? I think that in some cases it's not properly centered.

Pushed a commit, basically emptycontent is already a class name used by the server, so it interferes (thats why I do not like scoped styles but really recommend css modules for (new) projects).

@susnux susnux marked this pull request as ready for review November 28, 2023 12:40
@susnux susnux merged commit 1dff50a into main Nov 28, 2023
34 checks passed
@susnux susnux deleted the vue8_compatibility branch November 28, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

Assignees

@Chartman123 Chartman123

Labels
3. to review Waiting for reviews design Related to the design javascript Javascript related ticket technical debt Technical issue
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Chartman123 @susnux