Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: allow editing of submission by the user #1690

Draft
wants to merge 42 commits into
base: main
Choose a base branch
from
Draft

WIP: allow editing of submission by the user #1690

wants to merge 42 commits into from

Commits on Jan 5, 2024

  1. add new property allowEdit to forms 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    89a93a2 View commit details
    Browse the repository at this point in the history

  2. adjust tests, add allowEdit=false 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    21c04d9 View commit details
    Browse the repository at this point in the history

  3. update docs with allowEdit 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    112d919 View commit details
    Browse the repository at this point in the history

  4. setting allowEdit can now be edited 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    4f4a478 View commit details
    Browse the repository at this point in the history

  5. if AllowEdit is enabled, allow editing and pass the original submissi… 

    …on to the client

Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    e5b54a7 View commit details
    Browse the repository at this point in the history

  6. update Tests with answerMapper 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    821ef2b View commit details
    Browse the repository at this point in the history

  7. AllowEdit: Delete previous submissions by this user before submitting… 

    … new submission

Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    97f18f4 View commit details
    Browse the repository at this point in the history

  8. return selected values as a separate array 

    calculate the right id for the dropdown and radio buttons and checkboxes
load answers into the UI

Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    7ac7298 View commit details
    Browse the repository at this point in the history

  9. drop manual changes to the language files 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    fdcc303 View commit details
    Browse the repository at this point in the history

  10. fix for tests with AnswerMapper 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    004cec5 View commit details
    Browse the repository at this point in the history

  11. fix lint error 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    1c0b670 View commit details
    Browse the repository at this point in the history

  12. fix loading the answers in the browser 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    c88c003 View commit details
    Browse the repository at this point in the history

  13. do not create a new answer but modify answer 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    b71b866 View commit details
    Browse the repository at this point in the history

  14. fix author in new file 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    e620204 View commit details
    Browse the repository at this point in the history

  15. fix return type of findByFormAndUser 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    56f850e View commit details
    Browse the repository at this point in the history

  16. fix label for setting AllowEdit 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    47d8e94 View commit details
    Browse the repository at this point in the history

  17. update answers instead of always adding new answers 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    f2aaeeb View commit details
    Browse the repository at this point in the history

  18. refactoring: add new function storeAnswersForQuestion 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    26c696b View commit details
    Browse the repository at this point in the history

  19. use specific api end point for updating submission 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    0eccc99 View commit details
    Browse the repository at this point in the history

  20. throw Exceptions on wrong insert or update of submission 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    a92477e View commit details
    Browse the repository at this point in the history

  21. fix lint php issues 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    c163239 View commit details
    Browse the repository at this point in the history

  22. QuestionMultiple: load values for checkboxes and radio buttons from p… 

    …revious submission

Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    5b74589 View commit details
    Browse the repository at this point in the history

  23. fix for loading no answers on first submission 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    35e034a View commit details
    Browse the repository at this point in the history

  24. add and implement delete button for form submission 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    4baa61c View commit details
    Browse the repository at this point in the history

  25. update label in form settings 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    9f98978 View commit details
    Browse the repository at this point in the history

  26. fixes for Lint and Unit Tests 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    28bacf3 View commit details
    Browse the repository at this point in the history

  27. fixes for storing answers after rebase 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    ee64859 View commit details
    Browse the repository at this point in the history

  28. fix lint issues 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    4a2f18a View commit details
    Browse the repository at this point in the history

  29. fix typos in php code from merge 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    5dea217 View commit details
    Browse the repository at this point in the history

  30. fix unit tests 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    d29c325 View commit details
    Browse the repository at this point in the history

  31. fix more issues with unit tests and psalm tests 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    45f6bed View commit details
    Browse the repository at this point in the history

  32. fix according to coding standards 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    c5b4e1d View commit details
    Browse the repository at this point in the history

  33. fix: creation of dynamic property OCA\Forms\Tests\Unit\Service\FormsS… 

    …erviceTest:: is deprecated

Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    02caa93 View commit details
    Browse the repository at this point in the history

  34. The options allowEdit and submitMultiple exclude each other 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    d331578 View commit details
    Browse the repository at this point in the history

  35. small fixes for previous commit, enabling and disabling options in re… 

    …lation to allowEdit option

Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    f91e79d View commit details
    Browse the repository at this point in the history

  36. remove extra semicolon 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    226fe02 View commit details
    Browse the repository at this point in the history

  37. add confirmation for deleting submission 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    1124a97 View commit details
    Browse the repository at this point in the history

  38. revert change to CHANGELOG.md 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    995d9c3 View commit details
    Browse the repository at this point in the history

  39. fix space in DataStructure.md 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    d9dfa7c View commit details
    Browse the repository at this point in the history

  40. fix comment block for function storeAnswersForQuestion 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    0dc0f79 View commit details
    Browse the repository at this point in the history

  41. small fix for ApiController 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    cd1eafa View commit details
    Browse the repository at this point in the history

  42. another small fix for ApiController 

    Signed-off-by: Timotheus Pokorra <[email protected]>
    @tpokorra
    tpokorra committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    d60b3c4 View commit details
    Browse the repository at this point in the history