-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Sharing #1087
New Sharing #1087
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1087 +/- ##
============================================
+ Coverage 29.14% 32.04% +2.90%
- Complexity 369 435 +66
============================================
Files 36 40 +4
Lines 1431 1676 +245
============================================
+ Hits 417 537 +120
- Misses 1014 1139 +125 |
This comment was marked as outdated.
This comment was marked as outdated.
35c6c69
to
4634cb2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
fdb5553
to
736c089
Compare
9957233
to
4e9673b
Compare
d887be0
to
6c1c20d
Compare
Yes, we officially still support NC22 and just recently removed php 7.2. ^^ Thus i'd leave it for now. We'll have a separate PR to change all of our classes, when the time has come. 😉 |
a965002
to
20eae6a
Compare
Ok - So thank you, @artonge @CarlSchwan @come-nc for your reviews here! 🚀 Quite a few new things and ideas. I had a look onto all of it, partially just set a comment, but also implemented quite a few things. So - i think if there's no more issues from your side, this should be good to go, then! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good apart from nitpicking.
I did not test.
@artonge Do you wanna check your requested changes? Or should i just dismiss the review as i looked into your comments? |
Signed-off-by: Jonas Rittershofer <[email protected]>
Signed-off-by: Jonas Rittershofer <[email protected]>
Signed-off-by: Jonas Rittershofer <[email protected]>
Also fixes #806 Signed-off-by: Jonas Rittershofer <[email protected]>
Signed-off-by: Jonas Rittershofer <[email protected]>
Signed-off-by: Jonas Rittershofer <[email protected]>
Signed-off-by: Jonas Rittershofer <[email protected]>
Signed-off-by: Jonas Rittershofer <[email protected]>
🚀 🥳 |
So - here it is! 🎉 Ready for Review.
I'm really sorry, it became that much code now in a single PR. Thus i moved fixing the API-versioning to #1126.
Looking forward for the first tests!☺️
AppNavigation is now:
Fixes #425 😉