fix(export): remove new lines from form title in the exported filename

Signed-off-by: Thomas Citharel <[email protected]>
nextcloud · Oct 4, 2024 · 7443df3 · 7443df3
1 parent a692d13
commit 7443df3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/Service/FormsService.php b/lib/Service/FormsService.php
@@ -56,7 +56,7 @@
  */
 class FormsService {
 	private ?IUser $currentUser;
-	
+
 	public function __construct(
 		IUserSession $userSession,
 		private ActivityManager $activityManager,
@@ -780,6 +780,6 @@ public function getTemporaryUploadedFilePath(Form $form, Question $question): st
 	}
 
 	private static function normalizeFileName(string $fileName): string {
-		return str_replace(mb_str_split(\OCP\Constants::FILENAME_INVALID_CHARS), '-', $fileName);
+		return str_replace([...mb_str_split(\OCP\Constants::FILENAME_INVALID_CHARS), "\n"], '-', $fileName);
 	}
 }
diff --git a/tests/Unit/Service/FormsServiceTest.php b/tests/Unit/Service/FormsServiceTest.php
@@ -1445,6 +1445,13 @@ public function testGetFileNameThrowsAnExceptionForInvalidFormat() {
 		$this->formsService->getFileName($form, 'dummy');
 	}
 
+	public function testGetFileNameReplacesNewLines() {
+		$form = new Form();
+		$form->setTitle("Form \n new line");
+
+		$this->assertSame('Form - new line (responses).xlsx', $this->formsService->getFileName($form, 'xlsx'));
+	}
+
 	public function testGetFileName() {
 		$form = new Form();
 		$form->setTitle('Form 1');