Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable31] fix: Support sha-1 algo for user certificate signature #895

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Feb 6, 2025

Manual backport of #893

@artonge artonge added 3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket labels Feb 6, 2025
@artonge artonge added this to the Nextcloud 31 milestone Feb 6, 2025
@artonge artonge requested a review from skjnldsv February 6, 2025 11:20
@artonge artonge self-assigned this Feb 6, 2025
@artonge artonge changed the base branch from master to stable31 February 6, 2025 11:20
@artonge artonge force-pushed the artonge/backport/stable31/893 branch from 659248a to 4cc6c82 Compare February 6, 2025 11:20
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the artonge/backport/stable31/893 branch from 4cc6c82 to ca4e3d9 Compare February 6, 2025 11:20
@artonge artonge changed the title fix: Support sha-1 algo for user certificate signature [stable31] fix: Support sha-1 algo for user certificate signature Feb 6, 2025
@artonge artonge requested a review from nfebe February 6, 2025 11:33
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Project coverage is 38.28%. Comparing base (775aeda) to head (ca4e3d9).
Report is 5 commits behind head on stable31.

Files with missing lines Patch % Lines
src/services/webDavProxy.spec.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           stable31     #895      +/-   ##
============================================
+ Coverage     37.72%   38.28%   +0.55%     
============================================
  Files            33       33              
  Lines          1450     1468      +18     
  Branches         76       79       +3     
============================================
+ Hits            547      562      +15     
- Misses          901      904       +3     
  Partials          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artonge artonge enabled auto-merge February 6, 2025 15:15
@artonge artonge requested a review from susnux February 6, 2025 15:32
@artonge artonge merged commit 49a7742 into stable31 Feb 6, 2025
42 checks passed
@artonge artonge deleted the artonge/backport/stable31/893 branch February 6, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants