Added custom opcache config override #2275
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Rousseau <[email protected]>
|
This adds a lot of new envs. Do you require all of them? |
|
I think it's a good idea to be able to customize any OPcache setting. |
|
I'm a bit worried to add that many ENVs. I can imagine some cases where it's useful to adjust the numbers but why would you change |
J0WI
reviewed
Sep 22, 2024
| @@ -217,6 +217,15 @@ To customize Apache max file upload limit you can change the following variable: | |||
| - `APACHE_BODY_LIMIT` (default `1073741824` [1GiB]) This restricts the total | |||
| size of the HTTP request body sent from the client. It specifies the number of _bytes_ that are allowed in a request body. A value of **0** means **unlimited**. Check the [Nextcloud documentation](https://docs.nextcloud.com/server/latest/admin_manual/configuration_files/big_file_upload_configuration.html#apache) for more information. | |||
|
|
|||
| To customize OPcache parameters you can change the following variables: | |||
There was a problem hiding this comment.
Please mention https://docs.nextcloud.com/server/latest/admin_manual/installation/server_tuning.html#enable-php-opcache in this section
| @@ -217,6 +217,15 @@ To customize Apache max file upload limit you can change the following variable: | |||
| - `APACHE_BODY_LIMIT` (default `1073741824` [1GiB]) This restricts the total | |||
| size of the HTTP request body sent from the client. It specifies the number of _bytes_ that are allowed in a request body. A value of **0** means **unlimited**. Check the [Nextcloud documentation](https://docs.nextcloud.com/server/latest/admin_manual/configuration_files/big_file_upload_configuration.html#apache) for more information. | |||
|
|
|||
| To customize OPcache parameters you can change the following variables: | |||
| - `PHP_OPCACHE_INTERNED_STRINGS_BUFFER` (default `32`) The amount of memory used to store interned strings, in megabytes. | |||
| - `PHP_OPCACHE_MAX_ACCELERATED_FILES` (default `10000`) The maximum number of keys (and therefore scripts) in the OPcache hash table. The actual value used will be the first number in the set of prime numbers { 223, 463, 983, 1979, 3907, 7963, 16229, 32531, 65407, 130987, 262237, 524521, 1048793 } that is greater than or equal to the configured value. The minimum value is 200. The maximum value is 1000000. Values outside of this range are clamped to the permissible range. | |||
There was a problem hiding this comment.
We should not be too verbose here and copy the whole upstream documentation. Just link to https://www.php.net/manual/en/opcache.configuration.php#ini.opcache.max-accelerated-files for further details.
| - `PHP_OPCACHE_MAX_ACCELERATED_FILES` (default `10000`) The maximum number of keys (and therefore scripts) in the OPcache hash table. The actual value used will be the first number in the set of prime numbers { 223, 463, 983, 1979, 3907, 7963, 16229, 32531, 65407, 130987, 262237, 524521, 1048793 } that is greater than or equal to the configured value. The minimum value is 200. The maximum value is 1000000. Values outside of this range are clamped to the permissible range. | ||
| - `PHP_OPCACHE_MEMORY_CONSUMPTION` (default `128`) The size of the shared memory storage used by OPcache, in megabytes. The minimum permissible value is "8", which is enforced if a smaller value is set. | ||
| - `PHP_OPCACHE_SAVE_COMMENT` (default `1`) If disabled, all documentation comments will be discarded from the opcode cache to reduce the size of the optimised code. Disabling this configuration directive may break applications and frameworks that rely on comment parsing for annotations, including Doctrine, Zend Framework 2 and PHPUnit. | ||
| - `PHP_OPCACHE_REVALIDATE_FREQ` (default `60`) How often to check script timestamps for updates, in seconds. 0 will result in OPcache checking for updates on every request. |
There was a problem hiding this comment.
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to customize PHP OPcache configuration.
Default values have been set to environment variables that can be overridden.