Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disabled app list stays empty due to missing diffutils on Alpine #2254

Closed
wants to merge 1 commit into from

Conversation

Aakash788
Copy link
Contributor

@Aakash788 Aakash788 commented Jul 5, 2024

Fixes #1911

Description:
This PR fixes issue #1911 by installing diffutils in alpine image and made change in the Dockerfile-alpine.template. This ensures that the disabled app list is populated correctly.

Changes:

  • Updated Dockerfile-alpine.template to include diffutils in alpine docker image.

Testing:

  • Built the Docker image using the modified Dockerfile.
  • Verified that the issue with the empty disabled app list is resolved.

Additional Notes:

  • This is my first contribution to this project. Please let me know if there are any changes or improvements needed. I personally use nextcloud in my home-server and its awesome

Signed-off-by: Aakash788 <[email protected]>
@Aakash788
Copy link
Contributor Author

i am so sorry actually after committing this i found another good for first issue and i tried to also contribute that but accidentally commit that here please ignore my second commit. first commit is for #1911 and the second commit is for #1708.

@joshtrichards
Copy link
Member

Hi @Aakash788 - Thanks! If you can split out that second commit into a separate PR so it could be reviewed separately that would be appreciated (since they're quite different matters). Otherwise it'll block this PR from being reviewed/merged.

If it's easier, feel free to submit new PRs. If you create a new local branch for each fix, you can submit the PR from those dedicated branches. That may make your life easier too. :-)

@Aakash788
Copy link
Contributor Author

Hi @joshtrichards I've removed the second commit from the current PR. I'll submit it as a separate PR for separate review and thanks for the advice about using dedicated branches for each fix moving forward to keep things organized.

@joshtrichards joshtrichards changed the title Fixes Issue #1911: Disabled app list stays empty due to missing diffutils on Alpine fix: Disabled app list stays empty due to missing diffutils on Alpine Jul 5, 2024
@joshtrichards joshtrichards added this to the Nextcloud 29.0.4 milestone Jul 5, 2024
@joshtrichards joshtrichards added the feature: upgrading Upgrading an existing deployment to a new image/NC version label Jul 5, 2024
@joshtrichards joshtrichards requested a review from J0WI July 10, 2024 11:52
@J0WI
Copy link
Contributor

J0WI commented Jul 11, 2024

diff -u can be used for a more consistent output. I'd prefer that rather than adding something new.

#1213 suggests to remove the logic altogether.

@Aakash788 Aakash788 closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: upgrading Upgrading an existing deployment to a new image/NC version image: alpine Alpine image specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled app list stays empty due to missing diffutils on Alpine
3 participants