-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2165 #2166
Fix #2165 #2166
Conversation
Signed-off-by: Loïc Houpert <[email protected]>
Signed-off-by: Loïc Houpert <[email protected]>
Signed-off-by: Loïc Houpert <[email protected]>
Signed-off-by: Loïc Houpert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
11.3 is not really supported, the latest supported version is 10.11: https://docs.nextcloud.com/server/latest/admin_manual/installation/system_requirements.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No for me. This problem shouldn't (and doesn't AFAIK) occur if sticking with LTS MariaDB release versions that are actually supported officially by Nextcloud Server. :-)
https://mariadb.com/kb/en/mariadb-server-release-dates/
https://docs.nextcloud.com/server/latest/admin_manual/installation/system_requirements.html#server
How about we keep 10.6 as the version (or update to 10.11), and still add In my opinion, this is better than potentially running into the same issue again in the future. Worst case, someone has to analyse and fix this from scratch again because they won't find this issue right here. Correct me if my view on this is wrong. Edit: https://mariadb.com/docs/server/ref/cs10.6/character-sets/ supported charsets for 10.6 show utf8, so I guess the flag is fine Edit 2: #2165 (comment) okay, never mind then! Issue is solved. Still, explicitly defining the charset can prevent this from happening again. |
We may consider this again when this version is officially supported by Nextcloud but at the moment this is out of scope. There are already various ways to customize the images but we don't want to overload the examples to cover edge cases. |
To address #2165