Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] Avoid sql error on ONLY_FULL_GROUP_BY #6391

Merged
merged 1 commit into from
Oct 14, 2024
Merged

[stable28] Avoid sql error on ONLY_FULL_GROUP_BY #6391

merged 1 commit into from
Oct 14, 2024

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Oct 11, 2024 •
edited
Loading

@luka-nextcloud luka-nextcloud self-assigned this Oct 11, 2024
@luka-nextcloud luka-nextcloud changed the title fix: Avoid sql error on ONLY_FULL_GROUP_BY [stable28] Avoid sql error on ONLY_FULL_GROUP_BY Oct 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 66558 was 66366 (+0.28%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@juliusknorr
Copy link
Member

@luka-nextcloud Can you check the cypress failure on stable28 separately?

@juliusknorr juliusknorr merged commit 9a280b3 into stable28 Oct 14, 2024
30 of 31 checks passed
@juliusknorr juliusknorr deleted the backport/only-full-group-by-sql-error/stable28 branch October 14, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees

@luka-nextcloud luka-nextcloud

Labels
bug
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luka-nextcloud @juliusknorr