Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] fix: Avoid optional before required parameter #6094

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 12, 2024

Backport of PR #5794

Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 67586 was 67430 (+0.23%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

Copy link

cypress bot commented Jul 12, 2024

Passing run #1928 ↗︎

0 17 0 0 Flakiness 0

Details:

Merge 017fa30 into ddf9d55...
Project: Deck Commit: a88640e981 ℹ️
Status: Passed Duration: 02:38 💡
Started: Jul 12, 2024 7:33 AM Ended: Jul 12, 2024 7:36 AM

Review all test suite changes for PR #6094 ↗︎

@juliusknorr juliusknorr merged commit e7feac8 into stable27 Jul 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant