Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial cuda11.8 support #16

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Added initial cuda11.8 support #16

merged 2 commits into from
Mar 11, 2024

Conversation

nc-fkl
Copy link
Contributor

@nc-fkl nc-fkl commented Feb 29, 2024

Added cuda support and aligned readme

@nc-fkl nc-fkl force-pushed the feature/cuda-support branch 3 times, most recently from f3d6f55 to f4d603c Compare February 29, 2024 16:10
@marcelklehr
Copy link
Member

Can we rebase this and get the integration tests to pass?

Dockerfile.cuda11.8 Outdated Show resolved Hide resolved
Dockerfile.cuda11.8 Outdated Show resolved Hide resolved
Dockerfile.cuda11.8 Outdated Show resolved Hide resolved
Dockerfile.cuda11.8 Outdated Show resolved Hide resolved
Dockerfile.cuda11.8 Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
config.cuda.yaml Outdated Show resolved Hide resolved
@kyteinsky
Copy link
Contributor

Very detailed and self-explanatory readme! Nice!

One last thing: add the following env vars in the example.env but commented out. It will also be good to have a small note in the compex and manual installs (and maybe we should keep the term same, either complex or manual)
https://github.com/cloud-py-api/app_api/blob/main/lib/DeployActions/DockerActions.php#L403-L404

@nc-fkl nc-fkl force-pushed the feature/cuda-support branch 13 times, most recently from 806be0b to bbd53d2 Compare March 7, 2024 08:29
@nc-fkl nc-fkl force-pushed the feature/cuda-support branch 4 times, most recently from 95fe9a4 to f3231af Compare March 7, 2024 10:26
Comment on lines 110 to 118
- name: Set up Nextcloud PGSQL
if: ${{ matrix.databases == 'pgsql'}}
run: |
sleep 25
mkdir data
./occ maintenance:install --verbose --database=${{ matrix.databases }} --database-name=nextcloud --database-host=127.0.0.1 --database-port=$PGSQL_PORT --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
php -S localhost:8080 &

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant spaces

@nc-fkl nc-fkl force-pushed the feature/cuda-support branch 4 times, most recently from 39f81c6 to 4d3add5 Compare March 7, 2024 12:04
@kyteinsky kyteinsky changed the title Initial and added cuda11.8 support Added initial cuda11.8 support Mar 11, 2024
- Realigned readme and adjusted filenames for for the sake of clarity
- Realigned readme
- Adjusted requirements, dockerfile cuda, readme
- Added openblas to llama-cpp-python
- Made cuda files the default ones
- removed git and adjusted config.yaml
- adjusted counting
- adjusted pip install in oneline
- adjusted readme
- adjusted config.yaml
- adjusted tests for cpu testing
- fixed typo for requirements.dev.txt
- adjusted requirements because of version bug
- fixed python-apt in requirements, comming originaly from apt
- fixed requirements - unintended-updates coming from apt
- fixed requirements - zipp coming from apt
- adjusted integration-test with missing steps
- adjusted integration-test, removed duplicate nextcloud setup
- adjusted integration-test, made the two nextcloud setup more distinguishable
- added required libgirepository1.0-dev for integration-test
- removed prepare environment and aligned upgrade of setuptools line
- added preparation of environment
- cleaned requirements file
- Removed redundant spaces

Signed-off-by: Florian Klinger <[email protected]>
@nc-fkl nc-fkl force-pushed the feature/cuda-support branch from bf73e77 to 700ad14 Compare March 11, 2024 10:18
@kyteinsky kyteinsky merged commit 303f81f into master Mar 11, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/cuda-support branch March 11, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants