Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): allow adding attendees in simple editor #6594

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Dec 30, 2024

Resolves #6585

Screenshots

Read-only Editing Editing (no invitees)
spectacle_20241230_101853 spectacle_20241230_101918 spectacle_20241230_101934

@st3iny st3iny added 3. to review Waiting for reviews enhancement New feature request Feature: Editor labels Dec 30, 2024
@st3iny st3iny added this to the v5.1.0 milestone Dec 30, 2024
@st3iny st3iny self-assigned this Dec 30, 2024
@st3iny st3iny force-pushed the feat/editor/simple-invitees branch from eef4ca1 to 7953d6a Compare December 30, 2024 09:24
@st3iny st3iny changed the title feat(editor): always show invitees list and search bar feat(editor): allow adding attendees in simple editor Dec 30, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.41%. Comparing base (e2a85a4) to head (7953d6a).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6594   +/-   ##
=========================================
  Coverage     23.40%   23.41%           
  Complexity      472      472           
=========================================
  Files           249      249           
  Lines         11901    11899    -2     
  Branches       2282     2269   -13     
=========================================
  Hits           2786     2786           
+ Misses         8788     8786    -2     
  Partials        327      327           
Flag Coverage Δ
javascript 14.85% <ø> (+<0.01%) ⬆️
php 59.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny merged commit 7e355d8 into main Dec 30, 2024
38 checks passed
@st3iny st3iny deleted the feat/editor/simple-invitees branch December 30, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature request Feature: Editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow adding attendees in simple editor
3 participants