Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change behaviour to behavior #6559

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Dec 10, 2024

To use the same spelling for expected and actual.

To use the same spelling for expected and actual.

Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb added the 3. to review Waiting for reviews label Dec 10, 2024
@kesselb kesselb self-assigned this Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.41%. Comparing base (761a6cb) to head (eb3b186).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6559      +/-   ##
============================================
- Coverage     23.44%   23.41%   -0.03%     
  Complexity      472      472              
============================================
  Files           249      249              
  Lines         11888    11902      +14     
  Branches       2271     2282      +11     
============================================
  Hits           2787     2787              
- Misses         8774     8788      +14     
  Partials        327      327              
Flag Coverage Δ
javascript 14.84% <ø> (-0.03%) ⬇️
php 59.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SebastianKrupinski SebastianKrupinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's wrong with the Canadian spelling of Behaviour? 🤣 I mean if we do this for Behaviour, we are going to have to do it for Colour and Favourite 🤣

@kesselb
Copy link
Contributor Author

kesselb commented Dec 10, 2024

I don't have a strong opinion here, just found it weird to have "expected behavior" and "actual behaviour".

@SebastianKrupinski
Copy link
Contributor

I don't have a strong opinion here, just found it weird to have "expected behavior" and "actual behaviour".

Lol. Me either. I was just joking around.

@SebastianKrupinski SebastianKrupinski merged commit c1b7f8c into main Dec 10, 2024
37 of 38 checks passed
@SebastianKrupinski SebastianKrupinski deleted the chore/noid/bug-template branch December 10, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants