Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: invert edit simple checkbox #6555

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

GVodyanov
Copy link
Contributor

Found by @alexanderdd, currently the checkbox does the opposite of what it should

@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Dec 9, 2024
@GVodyanov GVodyanov self-assigned this Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.44%. Comparing base (7f70db9) to head (761a6cb).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6555   +/-   ##
=========================================
  Coverage     23.44%   23.44%           
  Complexity      472      472           
=========================================
  Files           249      249           
  Lines         11888    11888           
  Branches       2282     2271   -11     
=========================================
  Hits           2787     2787           
  Misses         8774     8774           
  Partials        327      327           
Flag Coverage Δ
javascript 14.87% <ø> (ø)
php 59.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SebastianKrupinski SebastianKrupinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Works.

@SebastianKrupinski SebastianKrupinski merged commit 02e45c6 into main Dec 9, 2024
37 checks passed
@SebastianKrupinski SebastianKrupinski deleted the fix/edit-simple-checkbox branch December 9, 2024 17:33
@SebastianKrupinski
Copy link
Contributor

Back port?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants