-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Appointment schedule" notion instead of only "Appointments" for a better UX #6371
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6371 +/- ##
=========================================
Coverage 23.54% 23.54%
Complexity 454 454
=========================================
Files 247 247
Lines 11700 11700
Branches 2214 2202 -12
=========================================
Hits 2755 2755
- Misses 8624 8625 +1
+ Partials 321 320 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
56ec6ed
to
9b725f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This exact issue came up in a design review call! :) The discussion led to the conclusion that "Appointment schedule" is more appropriate. This is also on parity with Google Calendar (with uses the wording "Appointment schedule" to set this up) and Calendly (which calls itself an "Appointment scheduling software"). What do you think?
Thanks for your reply @nimishavijay ! Despite "Appointment request form" remains my favorite wording (personal preference), your suggestion is of course the best one because it fits wordings used by Google and it will make UX transition easier for end users. So, I'll make some new commits. |
b655bbd
to
c0a4d4c
Compare
@nimishavijay changes are done ; can you check and test it ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Only a small change that I didn't notice before: "Appointment schedules" (plural form)
Signed-off-by: Jérôme Herbinet <[email protected]> "Appointment schedule", juste like G***** Signed-off-by: Jérôme Herbinet <[email protected]> "Appointment request form" notion Signed-off-by: Jérôme Herbinet <[email protected]> Update AppointmentConfigList.vue Signed-off-by: Jérôme Herbinet <[email protected]> Update AppointmentConfigModal.vue Signed-off-by: Jérôme Herbinet <[email protected]> "Appointment schedule" (and "Create new"), like Google Signed-off-by: Jérôme Herbinet <[email protected]> "Appointment schedule", like Google Signed-off-by: Jérôme Herbinet <[email protected]>
1793de2
to
2a87755
Compare
Done @nimishavijay |
"Appointment" notion is no clear and creates confusion because this feature don't directly create an appointment but create an "appointment request form". I propose a new notion : "Appointment request form".
I made some wording change test with my browser dev tools. Please check below (real tests from reviewers are welcome) :