Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable5.0] fix(attachmentService, propfindErrorParse): add an error message for when a file is not compatible for windows #6311

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 2, 2024

Backport of PR #6303

…when a file is not compatible for windows

Signed-off-by: Grigory Vodyanov <[email protected]>
@backportbot backportbot bot added the 3. to review Waiting for reviews label Sep 2, 2024
@backportbot backportbot bot added this to the v5.0.0 milestone Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 15.43%. Comparing base (0a3d656) to head (d2b4645).
Report is 3 commits behind head on stable5.0.

Files with missing lines Patch % Lines
src/utils/propfindErrorParse.js 0.00% 8 Missing ⚠️
src/services/attachmentService.js 0.00% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           stable5.0    #6311      +/-   ##
=============================================
- Coverage      15.45%   15.43%   -0.03%     
=============================================
  Files            205      206       +1     
  Lines           9429     9442      +13     
  Branches        2201     2194       -7     
=============================================
  Hits            1457     1457              
- Misses          7656     7667      +11     
- Partials         316      318       +2     
Flag Coverage Δ
javascript 15.43% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miaulalala miaulalala merged commit e24aaa6 into stable5.0 Sep 2, 2024
26 of 28 checks passed
@miaulalala miaulalala deleted the backport/6303/stable5.0 branch September 2, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants