Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues in free/busy suggestions #6175

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

GVodyanov
Copy link
Contributor

@GVodyanov GVodyanov commented Jul 17, 2024

Fix #6162

Improve the slot suggestions and make the algorithm more understandable

@GVodyanov GVodyanov added the 1. to develop Accepted and waiting to be taken care of label Jul 17, 2024
@GVodyanov GVodyanov self-assigned this Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 85.41667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 23.54%. Comparing base (343fe47) to head (aac9479).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/services/freeBusySlotService.js 87.23% 6 Missing ⚠️
src/components/Editor/FreeBusy/FreeBusy.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6175      +/-   ##
============================================
- Coverage     23.73%   23.54%   -0.19%     
  Complexity      454      454              
============================================
  Files           247      247              
  Lines         11731    11702      -29     
  Branches       2223     2213      -10     
============================================
- Hits           2784     2755      -29     
  Misses         8627     8627              
  Partials        320      320              
Flag Coverage Δ
javascript 15.07% <85.41%> (-0.26%) ⬇️
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GVodyanov GVodyanov added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Sep 5, 2024
@GVodyanov GVodyanov force-pushed the fix/free-busy-suggested-slots branch 2 times, most recently from 249eac4 to 50e76b2 Compare September 9, 2024 14:57
@GVodyanov
Copy link
Contributor Author

For people reviewing, this is how the suggested slots should work:

  • If the time you set for your event is free, it will be suggested, without being rounded (e.g. I set the time to 11:24-12:56, there are no blocking events in that period, that period will be suggested)

  • Aside from suggesting the current time if free, it will look at all the events found by the free busy service, and see if everyone is free immediately after. So say two people are unavailable until 08:00 and 09:00, immediately after 08:00 is invalid, but immediately after 09:00 is.

  • The time after the events will also be rounded to the nearest quarter-hour (so :00, :15, :30, :45), but always rounding up. There is always at least a minute of break between events, so say you have a blocking event ending at 13:00, the next event will be suggested at 13:15. If that blocking event were to end at 13:14, the next event would still be suggested at 13:15.

@GVodyanov GVodyanov marked this pull request as ready for review September 9, 2024 15:32
@GVodyanov GVodyanov added 3. to review Waiting for reviews enhancement New feature request and removed 2. developing Work in progress labels Sep 9, 2024
@miaulalala miaulalala merged commit 70c292e into main Sep 14, 2024
35 of 36 checks passed
@miaulalala miaulalala deleted the fix/free-busy-suggested-slots branch September 14, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Free/Busy Automatic slot suggestion doesn't suggest any slots any more
2 participants