chore: revert moment plugin factory pattern #6089
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use Pinia now and we don't have to pass a store to the moment plugin anymore. The factory pattern is thus not required anymore. Signed-off-by: Richard Steinmetz <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6089 +/- ##
=========================================
Coverage 29.71% 29.71%
Complexity 914 914
=========================================
Files 287 287
Lines 13835 13833 -2
Branches 2163 2152 -11
=========================================
Hits 4111 4111
+ Misses 9409 9408 -1
+ Partials 315 314 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Pinia now and we don't have to pass a store to the moment plugin anymore. The factory pattern is thus not required anymore.