Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Public" holiday calendar #5338

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

Jerome-Herbinet
Copy link
Member

"Holiday" (only) and "Public holiday" don't have the same meaning.
"Public holiday" is appropriate (and "Holiday" only is not).

Signed-off-by: Jérôme Herbinet <[email protected]>
@Jerome-Herbinet Jerome-Herbinet added 3. to review Waiting for reviews language l10n and translations labels Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9ac0475) 22.36% compared to head (60da65a) 22.36%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5338   +/-   ##
=========================================
  Coverage     22.36%   22.36%           
  Complexity      359      359           
=========================================
  Files           236      236           
  Lines         11554    11554           
  Branches       2250     2250           
=========================================
  Hits           2584     2584           
  Misses         8970     8970           
Flag Coverage Δ
javascript 14.00% <0.00%> (ø)
php 64.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts/AppNavigation/CalendarList/CalendarListNew.vue 0.00% <0.00%> (ø)
...ponents/Subscription/HolidaySubscriptionPicker.vue 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChristophWurst ChristophWurst merged commit e34b6f8 into main Jun 26, 2023
@ChristophWurst ChristophWurst deleted the Jerome-Herbinet-public-holiday-calendar-wording branch June 26, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews language l10n and translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants