Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump @nextcloud/eslint-plugin from 2.1.0 to 2.2.1 #711

Merged
merged 2 commits into from
May 9, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 23, 2024

Bumps @nextcloud/eslint-plugin from 2.1.0 to 2.2.1.

Release notes

Sourced from @​nextcloud/eslint-plugin's releases.

v2.2.1

What's Changed

Full Changelog: nextcloud-libraries/eslint-plugin@v2.2.0...v2.2.1

v2.2.0

2.2.0 - 2024-03-26

Added

  • feat: Add option to set a Nextcloud target version or parse the appinfo (#164)
  • feat: Add removed API from 28 and 29 (#180)

Fixed

  • Fix dependencies - jest is only a development dependency (#173)

Changed

  • Dependency updates
  • Node version updates to LTS (Node 20 and NPM 10)
Changelog

Sourced from @​nextcloud/eslint-plugin's changelog.

2.2.1 - 2024-04-21

Fixed

  • fix: Relax recommended config to work also with libraries (#180)

2.2.0 - 2024-03-26

Added

  • feat: Add option to set a Nextcloud target version or parse the appinfo (#164)
  • feat: Add removed API from 28 and 29 (#180)

Fixed

  • Fix dependencies - jest is only a development dependency (#173)

Changed

  • Dependency updates
  • Node version updates to LTS (Node 20 and NPM 10)
Commits
  • e410a18 chore: Prepare 2.2.1
  • abbe580 Merge pull request #185 from nextcloud-libraries/fix/relax-defaults
  • 2185b62 fix: Relax recommended config to work also with libraries
  • 957d471 Merge pull request #184 from nextcloud-libraries/dependabot/npm_and_yarn/memf...
  • e6ff23c chore(deps-dev): Bump memfs from 4.8.1 to 4.8.2
  • 47bfa86 Merge pull request #182 from nextcloud-libraries/dependabot/npm_and_yarn/memf...
  • ebb7894 chore(deps-dev): Bump memfs from 4.8.0 to 4.8.1
  • a4ed611 fix: Only publish needed files
  • 2a7ad7b Merge pull request #181 from nextcloud-libraries/chore/prepare-release
  • 32ec4d7 chore: Prepare 2.2.0 release
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@nextcloud/eslint-plugin](https://github.com/nextcloud-libraries/eslint-plugin) from 2.1.0 to 2.2.1.
- [Release notes](https://github.com/nextcloud-libraries/eslint-plugin/releases)
- [Changelog](https://github.com/nextcloud-libraries/eslint-plugin/blob/main/CHANGELOG.md)
- [Commits](nextcloud-libraries/eslint-plugin@v2.1.0...v2.2.1)

---
updated-dependencies:
- dependency-name: "@nextcloud/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 23, 2024
Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@st3iny
Copy link
Member

st3iny commented Apr 29, 2024

Something is broken in the plugin or we have an incorrect peer dependency.

> @nextcloud/[email protected] lint
> eslint --ext .js src


Oops! Something went wrong! :(

ESLint: 8.31.0

TypeError: Error while loading rule '@nextcloud/no-deprecations': The "path" argument must be of type string. Received undefined
Occurred while linting /home/richard/src/nextcloud-calendar-js/src/components/abstractComponent.js
    at validateString (node:internal/validators:162:11)
    at Object.isAbsolute (node:path:1160:5)
    at createVersionValidator (/home/richard/src/nextcloud-calendar-js/node_modules/@nextcloud/eslint-plugin/lib/utils/version-parser.js:76:33)
    at Object.create (/home/richard/src/nextcloud-calendar-js/node_modules/@nextcloud/eslint-plugin/lib/rules/no-deprecations.js:115:36)
    at createRuleListeners (/home/richard/src/nextcloud-calendar-js/node_modules/eslint/lib/linter/linter.js:923:21)
    at /home/richard/src/nextcloud-calendar-js/node_modules/eslint/lib/linter/linter.js:1105:110
    at Array.forEach (<anonymous>)
    at runRules (/home/richard/src/nextcloud-calendar-js/node_modules/eslint/lib/linter/linter.js:1042:34)
    at Linter._verifyWithoutProcessors (/home/richard/src/nextcloud-calendar-js/node_modules/eslint/lib/linter/linter.js:1394:31)
    at Linter._verifyWithConfigArray (/home/richard/src/nextcloud-calendar-js/node_modules/eslint/lib/linter/linter.js:1769:21)
    at Linter.verify (/home/richard/src/nextcloud-calendar-js/node_modules/eslint/lib/linter/linter.js:1476:65)
    at Linter.verifyAndFix (/home/richard/src/nextcloud-calendar-js/node_modules/eslint/lib/linter/linter.js:2028:29)
    at verifyText (/home/richard/src/nextcloud-calendar-js/node_modules/eslint/lib/cli-engine/cli-engine.js:245:48)
    at CLIEngine.executeOnFiles (/home/richard/src/nextcloud-calendar-js/node_modules/eslint/lib/cli-engine/cli-engine.js:823:28)
    at ESLint.lintFiles (/home/richard/src/nextcloud-calendar-js/node_modules/eslint/lib/eslint/eslint.js:551:23)
    at Object.execute (/home/richard/src/nextcloud-calendar-js/node_modules/eslint/lib/cli.js:417:36)
    at async main (/home/richard/src/nextcloud-calendar-js/node_modules/eslint/bin/eslint.js:135:24)

@susnux
Copy link
Contributor

susnux commented May 9, 2024

@st3iny
We need to increase the peer dependency version, but you can fix it here by updating your ESLint version to at least 8.40 or better 8.57

To make it compatible with our eslint plugin.

Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny st3iny enabled auto-merge May 9, 2024 08:42
@st3iny st3iny merged commit 6687c46 into main May 9, 2024
9 checks passed
@st3iny st3iny deleted the dependabot/npm_and_yarn/nextcloud/eslint-plugin-2.2.1 branch May 9, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants