fix: Add package exports to allow node16 projects to import module #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
=======================================
Coverage 91.01% 91.01%
=======================================
Files 57 57
Lines 2782 2782
Branches 507 507
=======================================
Hits 2532 2532
Misses 250 250 ☔ View full report in Codecov by Sentry. |
st3iny
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Didn't test but looks good. Thanks, learnt something today.
More on the topic: https://nodejs.org/api/packages.html#conditional-exports
| "module": "dist/index.esm.js", | ||
| "module": "dist/index.es.mjs", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For projects using
node16ornodeNextmodule resolution only theexportssection is evaluated, as the section is missing only themainentry is used which is umd (even if your project uses ESM).