fix: es interop with @nextcloud/axios #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
approved these changes
May 21, 2024
mejo-
approved these changes
May 22, 2024
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
mejo-
force-pushed
the
fix/es-interop-with-axios
branch
from
a1a99c0
to
8528ad3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 2 issues:
import {post} from '@nextcloud/axios'is not a valid ES import. There is nopostexported from@nextcloud/axios. It luckily worked when the module was only used in CJS with pure CJS because it is valid forrequire. But it is not valid forimport.CJSbut uses other libraries. It's good to support importing modules with_esModuleso "ESM-based" CJS libraries works fine. Enabled viaesModuleInterop: trueAlternative solution could also be using any bundler like Rollup or Vite and build an ESM version as well. In most cases an ESM version is used in our infra.